From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Xiang A Wang <xiang.a.wang@intel.com>
Subject: Re: [PATCH] mfd: lpss: Fix Intel Kaby Lake PCH-H properties
Date: Thu, 29 Sep 2016 13:13:34 +0300 [thread overview]
Message-ID: <20160929101334.GM1218@lahna.fi.intel.com> (raw)
In-Reply-To: <20160929095939.10236-1-jarkko.nikula@linux.intel.com>
On Thu, Sep 29, 2016 at 12:59:39PM +0300, Jarkko Nikula wrote:
> There are a few issues on Intel Kaby Lake PCH-H properties added by
> commit a6a576b78e09 ("mfd: lpss: Add Intel Kaby Lake PCH-H PCI IDs"):
>
> - Input clock of I2C controller on Intel Kaby Lake PCH-H is 120 MHz not
> 133 MHz. This was probably copy-paste error from Intel Broxton I2C
> properties.
> - There is no default I2C SDA hold time specified which is used when
> ACPI doesn't provide it. I got information from Windows driver team
> that Kaby Lake PCH-H can use the same configuration than Intel
> Sunrisepoint PCH.
> - Common HS-UART properties are not used.
>
> Fix these by reusing the Sunrisepoint properties on Kaby Lake PCH-H.
>
> Fixes: a6a576b78e09 ("mfd: lpss: Add Intel Kaby Lake PCH-H PCI IDs")
> Reported-by: Xiang A Wang <xiang.a.wang@intel.com>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Thanks for fixing this!
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2016-09-29 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 9:59 [PATCH] mfd: lpss: Fix Intel Kaby Lake PCH-H properties Jarkko Nikula
2016-09-29 10:13 ` Mika Westerberg [this message]
2016-10-26 10:00 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160929101334.GM1218@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox