* [PATCH 1/3] Docs: DT: Add National Instruments vendor prefix
@ 2016-09-28 16:59 Moritz Fischer
2016-09-28 16:59 ` [PATCH 2/3] mfd: cros_ec_spi: Add additional compatible string for NI version Moritz Fischer
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Moritz Fischer @ 2016-09-28 16:59 UTC (permalink / raw)
To: linux-kernel
Cc: robh+dt, mark.rutland, lee.jones, emilio.lopez, javier, treding,
shawnguo, jarkko.sakkinen, dmitry.torokhov, antonynpavlov,
devicetree, moritz.fischer.private, julia, Moritz Fischer
Add National Instruments (ni) vendor prefix to list of
vendor prefixes
Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 1992aa9..a92f62b 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -179,6 +179,7 @@ netlogic Broadcom Corporation (formerly NetLogic Microsystems)
netxeon Shenzhen Netxeon Technology CO., LTD
newhaven Newhaven Display International
nintendo Nintendo
+ni National Instruments Corp
nokia Nokia
nuvoton Nuvoton Technology Corporation
nvidia NVIDIA
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/3] mfd: cros_ec_spi: Add additional compatible string for NI version 2016-09-28 16:59 [PATCH 1/3] Docs: DT: Add National Instruments vendor prefix Moritz Fischer @ 2016-09-28 16:59 ` Moritz Fischer 2016-09-28 16:59 ` [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi Moritz Fischer 2016-10-04 13:29 ` [PATCH 1/3] Docs: DT: Add National Instruments vendor prefix Rob Herring 2 siblings, 0 replies; 6+ messages in thread From: Moritz Fischer @ 2016-09-28 16:59 UTC (permalink / raw) To: linux-kernel Cc: robh+dt, mark.rutland, lee.jones, emilio.lopez, javier, treding, shawnguo, jarkko.sakkinen, dmitry.torokhov, antonynpavlov, devicetree, moritz.fischer.private, julia, Moritz Fischer Document the alternative compatibility string for the NI version of the chromium embedded controller. Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com> --- Documentation/devicetree/bindings/mfd/cros-ec.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mfd/cros-ec.txt b/Documentation/devicetree/bindings/mfd/cros-ec.txt index 136e0c2..c49afa9 100644 --- a/Documentation/devicetree/bindings/mfd/cros-ec.txt +++ b/Documentation/devicetree/bindings/mfd/cros-ec.txt @@ -14,7 +14,7 @@ Required properties (I2C): - reg: I2C slave address Required properties (SPI): -- compatible: "google,cros-ec-spi" +- compatible: "google,cros-ec-spi" or "ni,cros-ec-spi" - reg: SPI chip select Optional properties (SPI): -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi 2016-09-28 16:59 [PATCH 1/3] Docs: DT: Add National Instruments vendor prefix Moritz Fischer 2016-09-28 16:59 ` [PATCH 2/3] mfd: cros_ec_spi: Add additional compatible string for NI version Moritz Fischer @ 2016-09-28 16:59 ` Moritz Fischer 2016-09-28 17:27 ` Dmitry Torokhov 2016-10-04 13:29 ` [PATCH 1/3] Docs: DT: Add National Instruments vendor prefix Rob Herring 2 siblings, 1 reply; 6+ messages in thread From: Moritz Fischer @ 2016-09-28 16:59 UTC (permalink / raw) To: linux-kernel Cc: robh+dt, mark.rutland, lee.jones, emilio.lopez, javier, treding, shawnguo, jarkko.sakkinen, dmitry.torokhov, antonynpavlov, devicetree, moritz.fischer.private, julia, Moritz Fischer Add compatible string for NI version of cros-ec-spi. Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com> --- drivers/mfd/cros_ec_spi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c index ebe9b94..e4504ec 100644 --- a/drivers/mfd/cros_ec_spi.c +++ b/drivers/mfd/cros_ec_spi.c @@ -708,6 +708,7 @@ static SIMPLE_DEV_PM_OPS(cros_ec_spi_pm_ops, cros_ec_spi_suspend, cros_ec_spi_resume); static const struct of_device_id cros_ec_spi_of_match[] = { + { .compatible = "ni,cros-ec-spi", }, { .compatible = "google,cros-ec-spi", }, { /* sentinel */ }, }; -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi 2016-09-28 16:59 ` [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi Moritz Fischer @ 2016-09-28 17:27 ` Dmitry Torokhov 2016-09-28 17:32 ` Moritz Fischer 0 siblings, 1 reply; 6+ messages in thread From: Dmitry Torokhov @ 2016-09-28 17:27 UTC (permalink / raw) To: Moritz Fischer Cc: lkml, Rob Herring, Mark Rutland, Lee Jones, Emilio López, Javier Martinez Canillas, Thierry Reding, Shawn Guo, Jarkko Sakkinen, antonynpavlov, devicetree@vger.kernel.org, moritz.fischer.private, julia On Wed, Sep 28, 2016 at 9:59 AM, Moritz Fischer <moritz.fischer@ettus.com> wrote: > Add compatible string for NI version of cros-ec-spi. > > Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com> > --- > drivers/mfd/cros_ec_spi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c > index ebe9b94..e4504ec 100644 > --- a/drivers/mfd/cros_ec_spi.c > +++ b/drivers/mfd/cros_ec_spi.c > @@ -708,6 +708,7 @@ static SIMPLE_DEV_PM_OPS(cros_ec_spi_pm_ops, cros_ec_spi_suspend, > cros_ec_spi_resume); > > static const struct of_device_id cros_ec_spi_of_match[] = { > + { .compatible = "ni,cros-ec-spi", }, I am confused: if the 2 controllers are the same, why do we need the new compat string, at least in the driver? Shouldn't DTS simply use "google,cros-ec-spi", or maybe both (compatible = "ni,cros-ec-spi", "google,cros-ec-spi")? DT folks, is there clear instructions somewhere as to when introduction of new compatible is warranted, along with the rules of how to settle on common fallback (i.e. how to make sure that, let's say, Linux, U-boot and FreeBSD use the same fallback compatible for the same series of devices)? > { .compatible = "google,cros-ec-spi", }, > { /* sentinel */ }, > }; > -- > 2.7.4 > Thanks. -- Dmitry ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi 2016-09-28 17:27 ` Dmitry Torokhov @ 2016-09-28 17:32 ` Moritz Fischer 0 siblings, 0 replies; 6+ messages in thread From: Moritz Fischer @ 2016-09-28 17:32 UTC (permalink / raw) To: Dmitry Torokhov Cc: lkml, Rob Herring, Mark Rutland, Lee Jones, Emilio López, Javier Martinez Canillas, Thierry Reding, Shawn Guo, Jarkko Sakkinen, antonynpavlov, devicetree@vger.kernel.org, moritz.fischer.private, julia Dmitry, On Wed, Sep 28, 2016 at 10:27 AM, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > On Wed, Sep 28, 2016 at 9:59 AM, Moritz Fischer > <moritz.fischer@ettus.com> wrote: >> Add compatible string for NI version of cros-ec-spi. >> >> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com> >> --- >> drivers/mfd/cros_ec_spi.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c >> index ebe9b94..e4504ec 100644 >> --- a/drivers/mfd/cros_ec_spi.c >> +++ b/drivers/mfd/cros_ec_spi.c >> @@ -708,6 +708,7 @@ static SIMPLE_DEV_PM_OPS(cros_ec_spi_pm_ops, cros_ec_spi_suspend, >> cros_ec_spi_resume); >> >> static const struct of_device_id cros_ec_spi_of_match[] = { >> + { .compatible = "ni,cros-ec-spi", }, > > I am confused: if the 2 controllers are the same, why do we need the > new compat string, at least in the driver? Shouldn't DTS simply use > "google,cros-ec-spi", or maybe both (compatible = "ni,cros-ec-spi", > "google,cros-ec-spi")? It might deviate in the future, but you're right, the driver patch is not required for now since we can use the fallback mechanism until there really *is* a difference. We can probably drop this one for now. Cheers, Moritz ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] Docs: DT: Add National Instruments vendor prefix 2016-09-28 16:59 [PATCH 1/3] Docs: DT: Add National Instruments vendor prefix Moritz Fischer 2016-09-28 16:59 ` [PATCH 2/3] mfd: cros_ec_spi: Add additional compatible string for NI version Moritz Fischer 2016-09-28 16:59 ` [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi Moritz Fischer @ 2016-10-04 13:29 ` Rob Herring 2 siblings, 0 replies; 6+ messages in thread From: Rob Herring @ 2016-10-04 13:29 UTC (permalink / raw) To: Moritz Fischer Cc: linux-kernel, mark.rutland, lee.jones, emilio.lopez, javier, treding, shawnguo, jarkko.sakkinen, dmitry.torokhov, antonynpavlov, devicetree, moritz.fischer.private, julia On Wed, Sep 28, 2016 at 09:59:19AM -0700, Moritz Fischer wrote: > Add National Instruments (ni) vendor prefix to list of > vendor prefixes > > Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com> > --- > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > index 1992aa9..a92f62b 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > @@ -179,6 +179,7 @@ netlogic Broadcom Corporation (formerly NetLogic Microsystems) > netxeon Shenzhen Netxeon Technology CO., LTD > newhaven Newhaven Display International > nintendo Nintendo > +ni National Instruments Corp ni comes before nintendo. > nokia Nokia > nuvoton Nuvoton Technology Corporation > nvidia NVIDIA > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-04 13:29 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-09-28 16:59 [PATCH 1/3] Docs: DT: Add National Instruments vendor prefix Moritz Fischer 2016-09-28 16:59 ` [PATCH 2/3] mfd: cros_ec_spi: Add additional compatible string for NI version Moritz Fischer 2016-09-28 16:59 ` [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi Moritz Fischer 2016-09-28 17:27 ` Dmitry Torokhov 2016-09-28 17:32 ` Moritz Fischer 2016-10-04 13:29 ` [PATCH 1/3] Docs: DT: Add National Instruments vendor prefix Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox