* [PATCH] x86: xen: move cpu_up functions out of ifdef
@ 2016-10-12 15:20 Arnd Bergmann
2016-10-12 15:29 ` Boris Ostrovsky
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-10-12 15:20 UTC (permalink / raw)
To: Boris Ostrovsky
Cc: Arnd Bergmann, David Vrabel, Juergen Gross, Thomas Gleixner,
Ingo Molnar, H. Peter Anvin, x86, Andy Lutomirski,
Vitaly Kuznetsov, Luis R. Rodriguez, Borislav Petkov,
Stefano Stabellini, xen-devel, linux-kernel
Three newly introduced functions are not defined when CONFIG_XEN_PVHVM is
disabled, but are still being used:
arch/x86/xen/enlighten.c:141:12: warning: ‘xen_cpu_up_prepare’ used but never defined
arch/x86/xen/enlighten.c:142:12: warning: ‘xen_cpu_up_online’ used but never defined
arch/x86/xen/enlighten.c:143:12: warning: ‘xen_cpu_dead’ used but never defined
Fixes: 4d737042d6c4 ("xen/x86: Convert to hotplug state machine")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/x86/xen/enlighten.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index c0fdd57da7aa..bdd855685403 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -1837,6 +1837,7 @@ static void __init init_hvm_pv_info(void)
xen_domain_type = XEN_HVM_DOMAIN;
}
+#endif
static int xen_cpu_up_prepare(unsigned int cpu)
{
@@ -1887,6 +1888,7 @@ static int xen_cpu_up_online(unsigned int cpu)
return 0;
}
+#ifdef CONFIG_XEN_PVHVM
#ifdef CONFIG_KEXEC_CORE
static void xen_hvm_shutdown(void)
{
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] x86: xen: move cpu_up functions out of ifdef
2016-10-12 15:20 [PATCH] x86: xen: move cpu_up functions out of ifdef Arnd Bergmann
@ 2016-10-12 15:29 ` Boris Ostrovsky
0 siblings, 0 replies; 2+ messages in thread
From: Boris Ostrovsky @ 2016-10-12 15:29 UTC (permalink / raw)
To: Arnd Bergmann
Cc: David Vrabel, Juergen Gross, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, x86, Andy Lutomirski, Vitaly Kuznetsov,
Luis R. Rodriguez, Borislav Petkov, Stefano Stabellini, xen-devel,
linux-kernel
On 10/12/2016 11:20 AM, Arnd Bergmann wrote:
> Three newly introduced functions are not defined when CONFIG_XEN_PVHVM is
> disabled, but are still being used:
>
> arch/x86/xen/enlighten.c:141:12: warning: ‘xen_cpu_up_prepare’ used but never defined
> arch/x86/xen/enlighten.c:142:12: warning: ‘xen_cpu_up_online’ used but never defined
> arch/x86/xen/enlighten.c:143:12: warning: ‘xen_cpu_dead’ used but never defined
>
> Fixes: 4d737042d6c4 ("xen/x86: Convert to hotplug state machine")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-12 15:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-12 15:20 [PATCH] x86: xen: move cpu_up functions out of ifdef Arnd Bergmann
2016-10-12 15:29 ` Boris Ostrovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox