* [PATCH] Staging:board:board: fix implicit declaration of function @ 2016-10-23 21:05 Nadim Almas 2016-10-24 10:46 ` Dan Carpenter 0 siblings, 1 reply; 3+ messages in thread From: Nadim Almas @ 2016-10-23 21:05 UTC (permalink / raw) To: gregkh; +Cc: devel, linux-kernel implicit declaration of function ‘of_find_all_nodes’ reported by sparse Signed-off-by: Nadim Almas <nadim.902@gmail.com> --- drivers/staging/board/board.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/board/board.c b/drivers/staging/board/board.c index 86dc411..6978db5 100644 --- a/drivers/staging/board/board.c +++ b/drivers/staging/board/board.c @@ -22,6 +22,7 @@ #include "board.h" +struct device_node *of_find_all_nodes(struct device_node *); static struct device_node *irqc_node __initdata; static unsigned int irqc_base __initdata; -- 2.7.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging:board:board: fix implicit declaration of function 2016-10-23 21:05 [PATCH] Staging:board:board: fix implicit declaration of function Nadim Almas @ 2016-10-24 10:46 ` Dan Carpenter 2016-10-24 11:11 ` Geert Uytterhoeven 0 siblings, 1 reply; 3+ messages in thread From: Dan Carpenter @ 2016-10-24 10:46 UTC (permalink / raw) To: Nadim Almas; +Cc: gregkh, devel, linux-kernel On Mon, Oct 24, 2016 at 02:35:26AM +0530, Nadim Almas wrote: > implicit declaration of function ‘of_find_all_nodes’ reported by sparse > No. Include the correct header file instead. regards, dan carpenter ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging:board:board: fix implicit declaration of function 2016-10-24 10:46 ` Dan Carpenter @ 2016-10-24 11:11 ` Geert Uytterhoeven 0 siblings, 0 replies; 3+ messages in thread From: Geert Uytterhoeven @ 2016-10-24 11:11 UTC (permalink / raw) To: Dan Carpenter Cc: Nadim Almas, Greg KH, driverdevel, linux-kernel@vger.kernel.org On Mon, Oct 24, 2016 at 12:46 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > On Mon, Oct 24, 2016 at 02:35:26AM +0530, Nadim Almas wrote: >> implicit declaration of function ‘of_find_all_nodes’ reported by sparse >> > > No. Include the correct header file instead. drivers/staging/board/board.c already includes <linux/of.h>, which provides the prototype, but only if CONFIG_OF=y. However, STAGING_BOARD depends on OF_ADDRESS and OF_IRQ, which both depend on OF. So how can this happen?? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-24 11:11 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-10-23 21:05 [PATCH] Staging:board:board: fix implicit declaration of function Nadim Almas 2016-10-24 10:46 ` Dan Carpenter 2016-10-24 11:11 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox