From: Sakari Ailus <sakari.ailus@iki.fi>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0
Date: Tue, 13 Dec 2016 11:43:47 +0200 [thread overview]
Message-ID: <20161213094346.GW16630@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <1481594282-12801-1-git-send-email-hofrat@osadl.org>
Hi Nicholas,
On Tue, Dec 13, 2016 at 02:58:02AM +0100, Nicholas Mc Guire wrote:
> As this is not in atomic context and it does not seem like a critical
> timing setting a range of 1ms allows the timer subsystem to optimize
> the hrtimer here.
I'd suggest not to. These delays are often directly visible to the user in
use cases where attention is indeed paid to milliseconds.
The same applies to register accesses. An delay of 0 to 100 µs isn't much as
such, but when you multiply that with the number of accesses it begins to
add up.
--
Kind regards,
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
next prev parent reply other threads:[~2016-12-13 9:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161213015743epcas3p19867fa74e5ffe2974364d317d9b494f6@epcas3p1.samsung.com>
2016-12-13 1:58 ` [PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Nicholas Mc Guire
2016-12-13 9:43 ` Sakari Ailus [this message]
2016-12-13 10:10 ` Ian Arkver
2016-12-13 10:54 ` Sakari Ailus
2016-12-13 12:38 ` Sylwester Nawrocki
2016-12-13 14:10 ` Laurent Pinchart
2016-12-13 14:53 ` Sylwester Nawrocki
2016-12-15 1:14 ` Nicholas Mc Guire
2016-12-15 17:45 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161213094346.GW16630@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=hans.verkuil@cisco.com \
--cc=hofrat@osadl.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox