From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Nicholas Mc Guire <hofrat@osadl.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0
Date: Thu, 15 Dec 2016 18:45:54 +0100 [thread overview]
Message-ID: <32517dbe-f893-fb7e-e3e2-dca7f6ca5e7f@samsung.com> (raw)
In-Reply-To: <20161215011405.GB22190@osadl.at>
On 12/15/2016 02:14 AM, Nicholas Mc Guire wrote:
> if its actually unused then it might be best to completely drop the code
> raher than fixing up dead-code. Is the EXYNOS the only system that had
> this device in use ? If it shold stay in then setting it to the above
> proposed 3000, 4000 would seem the most resonable to me as I asume this
> change would stay untested.
I agree, there little sense in modifying unused code which cannot be
tested anyway. The whole driver is a candidate for removal as it has
no users in mainline. AFAIK it had only been used on Exynos platforms.
I'd suggest to just drop the delay call, there are already usleep_range()
calls after the GPIO state change. IIRC the delay was needed to ensure
proper I2C bus operation after enabling the voltage level translator,
but I'm not 100% sure.
--
Thanks,
Sylwester
prev parent reply other threads:[~2016-12-15 17:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161213015743epcas3p19867fa74e5ffe2974364d317d9b494f6@epcas3p1.samsung.com>
2016-12-13 1:58 ` [PATCH RFC] [media] s5k6aa: set usleep_range greater 0 Nicholas Mc Guire
2016-12-13 9:43 ` Sakari Ailus
2016-12-13 10:10 ` Ian Arkver
2016-12-13 10:54 ` Sakari Ailus
2016-12-13 12:38 ` Sylwester Nawrocki
2016-12-13 14:10 ` Laurent Pinchart
2016-12-13 14:53 ` Sylwester Nawrocki
2016-12-15 1:14 ` Nicholas Mc Guire
2016-12-15 17:45 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32517dbe-f893-fb7e-e3e2-dca7f6ca5e7f@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=der.herr@hofr.at \
--cc=hans.verkuil@cisco.com \
--cc=hofrat@osadl.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox