From: Matthew Smith <matthew.s3h@gmail.com>
To: Laura Abbott <labbott@redhat.com>
Cc: greg@kroah.com, devel@driverdev.osuosl.org, arve@android.com,
riandrews@android.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: android: remove ION_IOC_SYNC
Date: Fri, 16 Dec 2016 23:27:08 +0000 [thread overview]
Message-ID: <20161216232708.GA4028@steamroller> (raw)
In-Reply-To: <7d594698-9b16-e296-1e84-10451e0ced4b@redhat.com>
On Fri, Dec 16, 2016 at 03:05:54PM -0800, Laura Abbott wrote:
> The 'remove' from that TODO is more than just removing the code.
> There's also an implicit 'replace it with something else'. The
> work to do this is still ongoing (see some of my latest patches).
> NAK for all 3 of these patches right now.
Ah that makes a bit more sense.
> The patches themselves looked structurally good. For your commit
> message next time, explain why the code was being changed, not
> just what was changed.
Thank you for the advice, I'll remember that for next time :)
prev parent reply other threads:[~2016-12-16 23:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 22:42 [PATCH 1/3] staging: android: remove ION_IOC_SYNC Matthew Smith
2016-12-16 22:42 ` [PATCH 2/3] staging: android: remove ION_IOC_CUSTOM Matthew Smith
2016-12-16 22:42 ` [PATCH 3/3] staging: android: remove compat_get_ion_custom_data Matthew Smith
2016-12-16 23:05 ` [PATCH 1/3] staging: android: remove ION_IOC_SYNC Laura Abbott
2016-12-16 23:27 ` Matthew Smith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161216232708.GA4028@steamroller \
--to=matthew.s3h@gmail.com \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox