The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Kenneth Lee <liguozhu@hisilicon.com>
Cc: dledford@redhat.com, sean.hefty@intel.com,
	hal.rosenstock@gmail.com, robin.murphy@arm.com, jroedel@suse.de,
	egtvedt@samfundet.no, vgupta@synopsys.com,
	dave.hansen@linux.intel.com, lstoakes@gmail.com, krzk@kernel.org,
	sebott@linux.vnet.ibm.com, markb@mellanox.com,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ib umem: bugfix: mixed put_pid()s in ib_umem_get()
Date: Thu, 29 Dec 2016 07:29:40 +0200	[thread overview]
Message-ID: <20161229052940.GH26885@mtr-leonro.local> (raw)
In-Reply-To: <1482978283-201678-1-git-send-email-liguozhu@hisilicon.com>

[-- Attachment #1: Type: text/plain, Size: 723 bytes --]

On Thu, Dec 29, 2016 at 10:24:43AM +0800, Kenneth Lee wrote:
> There are two bugfixes in this patch:
>
> 1. When the execution go to the ib_umem_odp_get() path, pid should be put
>    back.
> 2. When the memory allocation fail, the pid also should be put back before
>    exit.
>
> Signed-off-by: Kenneth Lee <liguozhu@hisilicon.com>

Hi Kenneth,

Thank you for resubmitting it. This fix is important and no doubts that
it will be accepted, however you need to improve the patch a little bit
more.

CAn you please resubmit it according to Documentation/SubmittingPatches
and reviewers feedback?

Haggai's Reviewed-by tag, Fixes, changelog, version in title and
proper title (see it in git log for this subsystems).

Thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2016-12-29  5:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-29  2:24 [PATCH] ib umem: bugfix: mixed put_pid()s in ib_umem_get() Kenneth Lee
2016-12-29  5:29 ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161229052940.GH26885@mtr-leonro.local \
    --to=leon@kernel.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=dledford@redhat.com \
    --cc=egtvedt@samfundet.no \
    --cc=hal.rosenstock@gmail.com \
    --cc=jroedel@suse.de \
    --cc=krzk@kernel.org \
    --cc=liguozhu@hisilicon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=lstoakes@gmail.com \
    --cc=markb@mellanox.com \
    --cc=robin.murphy@arm.com \
    --cc=sean.hefty@intel.com \
    --cc=sebott@linux.vnet.ibm.com \
    --cc=vgupta@synopsys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox