From: Jiri Olsa <jolsa@redhat.com>
To: Matija Glavinic Pecotic <matija.glavinic-pecotic.ext@nokia.com>
Cc: linux-kernel@vger.kernel.org, namhyung@kernel.org,
acme@redhat.com, Masami Hiramatsu <mhiramat@kernel.org>,
"Sverdlin,
Alexander (Nokia - DE/Ulm)" <alexander.sverdlin@nokia.com>
Subject: Re: [PATCH] perf: Fix looking up dwarf unwind stack info
Date: Wed, 18 Jan 2017 14:10:50 +0100 [thread overview]
Message-ID: <20170118131050.GA22162@krava> (raw)
In-Reply-To: <d309d40a-463f-482b-68e1-1465326efdc1@nokia.com>
On Tue, Jan 17, 2017 at 03:50:35PM +0100, Matija Glavinic Pecotic wrote:
SNIP
> extern int
> UNW_OBJ(dwarf_search_unwind_table) (unw_addr_space_t as,
> @@ -297,15 +298,58 @@ static int read_unwind_spec_debug_frame(struct dso *dso,
> int fd;
> u64 ofs = dso->data.debug_frame_offset;
>
> + /* debug_frame can reside in:
> + * - dso
> + * - debug pointed by symsrc_filename
> + * - gnu_debuglink, which doesn't necessary
> + * has to be pointed by symsrc_filename
> + */
looks like we could use this in other parts,
like when __get_srcline and similar
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
next prev parent reply other threads:[~2017-01-18 13:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 14:50 [PATCH] perf: Fix looking up dwarf unwind stack info Matija Glavinic Pecotic
2017-01-18 13:10 ` Jiri Olsa [this message]
2017-01-26 15:25 ` [tip:perf/core] perf unwind: " tip-bot for Matija Glavinic Pecotic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118131050.GA22162@krava \
--to=jolsa@redhat.com \
--cc=acme@redhat.com \
--cc=alexander.sverdlin@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matija.glavinic-pecotic.ext@nokia.com \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox