From: Greg KH <gregkh@linuxfoundation.org>
To: Abhijit Naik <abhijitnaik27@gmail.com>
Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
bhaktipriya96@gmail.com, daniel.baluta@intel.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixed coding style issues of xmit_linux.c
Date: Fri, 3 Feb 2017 22:12:14 +0100 [thread overview]
Message-ID: <20170203211214.GA18478@kroah.com> (raw)
In-Reply-To: <20170203141926.18368-1-abhijitnaik27@gmail.com>
On Fri, Feb 03, 2017 at 07:49:26PM +0530, Abhijit Naik wrote:
> This patch will increase readability of xmit_linux.c file.
>
> Removed following type of coding style warnings generated for xmit_linux.c,
> 1. Braces {} are not necessary for single statement blocks
> 2. Block comments use a trailing */ on a separate line
When you have to list the different things you do in a kernel patch,
that's a huge flag that you need to break this up into multiple patches.
Please do that here.
Also, please fix up your subject to be better suited to this subsystem
and driver, look at the other patches that have been made to this part
of the kernel to get an idea of what you need to do.
thanks,
greg k-h
prev parent reply other threads:[~2017-02-03 21:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 14:19 [PATCH] Fixed coding style issues of xmit_linux.c Abhijit Naik
2017-02-03 21:12 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203211214.GA18478@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=abhijitnaik27@gmail.com \
--cc=bhaktipriya96@gmail.com \
--cc=daniel.baluta@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox