[PATCH] Fixed coding style issues of xmit_linux.c

[PATCH] Fixed coding style issues of xmit_linux.c

[Abhijit Naik]

This patch will increase readability of xmit_linux.c file.

Removed following type of coding style warnings generated for xmit_linux.c,
	1. Braces {} are not necessary for single statement blocks
	2. Block comments use a trailing */ on a separate line

Signed-off-by: Abhijit Naik <abhijitnaik27@gmail.com>
---
 drivers/staging/rtl8712/xmit_linux.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c
index 695f9b9..1e86133 100644
--- a/drivers/staging/rtl8712/xmit_linux.c
+++ b/drivers/staging/rtl8712/xmit_linux.c
@@ -91,7 +91,8 @@ void r8712_set_qos(struct pkt_file *ppktfile, struct pkt_attrib *pattrib)
 	} else {
 		/* "When priority processing of data frames is supported,
 		 * a STA's SME should send EAPOL-Key frames at the highest
-		 * priority." */
+		 * priority."
+		 */
 
 		if (pattrib->ether_type == 0x888e)
 			UserPriority = 7;
@@ -162,16 +163,16 @@ int r8712_xmit_entry(_pkt *pkt, struct  net_device *pnetdev)
 	struct _adapter *padapter = netdev_priv(pnetdev);
 	struct xmit_priv *pxmitpriv = &(padapter->xmitpriv);
 
-	if (!r8712_if_up(padapter)) {
+	if (!r8712_if_up(padapter))
 		goto _xmit_entry_drop;
-	}
+
 	pxmitframe = r8712_alloc_xmitframe(pxmitpriv);
-	if (!pxmitframe) {
+	if (!pxmitframe)
 		goto _xmit_entry_drop;
-	}
-	if ((!r8712_update_attrib(padapter, pkt, &pxmitframe->attrib))) {
+
+	if ((!r8712_update_attrib(padapter, pkt, &pxmitframe->attrib)))
 		goto _xmit_entry_drop;
-	}
+
 	padapter->ledpriv.LedControlHandler(padapter, LED_CTL_TX);
 	pxmitframe->pkt = pkt;
 	if (r8712_pre_xmit(padapter, pxmitframe)) {
-- 
2.10.2

Re: [PATCH] Fixed coding style issues of xmit_linux.c

[Greg KH]

On Fri, Feb 03, 2017 at 07:49:26PM +0530, Abhijit Naik wrote:
> This patch will increase readability of xmit_linux.c file.
> 
> Removed following type of coding style warnings generated for xmit_linux.c,
> 	1. Braces {} are not necessary for single statement blocks
> 	2. Block comments use a trailing */ on a separate line

When you have to list the different things you do in a kernel patch,
that's a huge flag that you need to break this up into multiple patches.

Please do that here.

Also, please fix up your subject to be better suited to this subsystem
and driver, look at the other patches that have been made to this part
of the kernel to get an idea of what you need to do.

thanks,

greg k-h