public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	peterz@infradead.org, alexander.shishkin@linux.intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] perf tools: Support end symbols with no size for filters
Date: Thu, 9 Feb 2017 14:59:27 -0800	[thread overview]
Message-ID: <20170209225927.GB15301@tassilo.jf.intel.com> (raw)
In-Reply-To: <33fb6f80-a355-d093-0237-f8cb39ab0de7@intel.com>

> > -		no_size = !!size;
> 
> Erk!  Isn't the logic is the wrong way around here.  Sorry!
> i.e. should be:

Yes it works with that change too.

> 
> diff --git a/tools/perf/util/auxtrace.c b/tools/perf/util/auxtrace.c
> index c5a6e0b12452..78bd632f144d 100644
> --- a/tools/perf/util/auxtrace.c
> +++ b/tools/perf/util/auxtrace.c
> @@ -1826,7 +1826,7 @@ static int addr_filter__resolve_kernel_syms(struct addr_filter *filt)
>  		filt->addr = start;
>  		if (filt->range && !filt->size && !filt->sym_to) {
>  			filt->size = size;
> -			no_size = !!size;
> +			no_size = !size;
>  		}
>  	}
>  
> @@ -1840,7 +1840,7 @@ static int addr_filter__resolve_kernel_syms(struct addr_filter *filt)
>  		if (err)
>  			return err;
>  		filt->size = start + size - filt->addr;
> -		no_size = !!size;
> +		no_size = !size;
>  	}
>  

      reply	other threads:[~2017-02-09 23:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-03 22:18 [PATCH 1/2] perf/core: Allow global address filtering for kernel code Andi Kleen
2017-02-03 22:18 ` [PATCH 2/2] perf tools: Support end symbols with no size for filters Andi Kleen
2017-02-06 13:15   ` Adrian Hunter
2017-02-09 22:59     ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170209225927.GB15301@tassilo.jf.intel.com \
    --to=ak@linux.intel.com \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox