From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m32r: mm: fix build warning
Date: Wed, 15 Feb 2017 11:38:22 +0000 [thread overview]
Message-ID: <20170215113822.GA10057@sudip-tp> (raw)
In-Reply-To: <20170214141551.93d31680b42e255b7c604e51@linux-foundation.org>
On Tue, Feb 14, 2017 at 02:15:51PM -0800, Andrew Morton wrote:
> On Tue, 14 Feb 2017 22:05:45 +0000 Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote:
>
> > The build of m32r was giving warning:
> > mm/pgtable-generic.c: In function 'ptep_clear_flush':
> > mm/pgtable-generic.c:76:20: warning:
> > unused variable 'mm' [-Wunused-variable]
> >
> > The implementation of ptep_get_and_clear() and pte_accessible()
> > does not use 'mm'.
>
> That's because ptep_get_and_clear() and pte_accessible() are
> implemented as macros. If they were (static inline) C functions then
> this warning wouldn't occur. All the other architectures get this
> right.
oops.. sorry.. usually I will check all the other arch before sending a
patch but missed it this time.
Will investigate further today and send you a modified patch.
Regards
Sudip
next prev parent reply other threads:[~2017-02-15 11:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 22:05 [PATCH] m32r: mm: fix build warning Sudip Mukherjee
2017-02-14 22:15 ` Andrew Morton
2017-02-15 11:38 ` Sudip Mukherjee [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-01-28 13:10 Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170215113822.GA10057@sudip-tp \
--to=sudipm.mukherjee@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox