[PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches

[PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches

[Dmitry Torokhov]

The OF device table must be terminated, otherwise we'll be walking past
it and into areas unknown.

This causes KASAN errors reported by 0day kernel testing robot.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Tested-by: Fengguang Wu <fengguang.wu@intel.com>
Fixes: 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple ASCII...")
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/auxdisplay/img-ascii-lcd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/auxdisplay/img-ascii-lcd.c b/drivers/auxdisplay/img-ascii-lcd.c
index bf43b5d2aafc..83f1439e57fd 100644
--- a/drivers/auxdisplay/img-ascii-lcd.c
+++ b/drivers/auxdisplay/img-ascii-lcd.c
@@ -218,6 +218,7 @@ static const struct of_device_id img_ascii_lcd_matches[] = {
 	{ .compatible = "img,boston-lcd", .data = &boston_config },
 	{ .compatible = "mti,malta-lcd", .data = &malta_config },
 	{ .compatible = "mti,sead3-lcd", .data = &sead3_config },
+	{ /* sentinel */ }
 };
 
 /**
-- 
2.11.0.483.g087da7b7c-goog


-- 
Dmitry

Re: [PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches

[Paul Burton]

[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]

Hi Dmitry,

On Monday, 20 February 2017 21:39:11 PST Dmitry Torokhov wrote:
> The OF device table must be terminated, otherwise we'll be walking past
> it and into areas unknown.
> 
> This causes KASAN errors reported by 0day kernel testing robot.
> 
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Tested-by: Fengguang Wu <fengguang.wu@intel.com>
> Fixes: 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple
> ASCII...") Cc: stable@vger.kernel.org
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

An essentially identical patch was already submitted over here:

https://patchwork.kernel.org/patch/9493973/

I'm not sure how it ought to get into mainline - since the driver went through 
the MIPS tree perhaps this fix can too?

Thanks,
    Paul

> ---
>  drivers/auxdisplay/img-ascii-lcd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/auxdisplay/img-ascii-lcd.c
> b/drivers/auxdisplay/img-ascii-lcd.c index bf43b5d2aafc..83f1439e57fd
> 100644
> --- a/drivers/auxdisplay/img-ascii-lcd.c
> +++ b/drivers/auxdisplay/img-ascii-lcd.c
> @@ -218,6 +218,7 @@ static const struct of_device_id img_ascii_lcd_matches[]
> = { { .compatible = "img,boston-lcd", .data = &boston_config },
>  	{ .compatible = "mti,malta-lcd", .data = &malta_config },
>  	{ .compatible = "mti,sead3-lcd", .data = &sead3_config },
> +	{ /* sentinel */ }
>  };
> 
>  /**


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches

[Javier Martinez Canillas]

Hello Paul,

On 02/24/2017 06:56 PM, Paul Burton wrote:
> Hi Dmitry,
> 
> On Monday, 20 February 2017 21:39:11 PST Dmitry Torokhov wrote:
>> The OF device table must be terminated, otherwise we'll be walking past
>> it and into areas unknown.
>>
>> This causes KASAN errors reported by 0day kernel testing robot.
>>
>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>> Tested-by: Fengguang Wu <fengguang.wu@intel.com>
>> Fixes: 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple
>> ASCII...") Cc: stable@vger.kernel.org
>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> An essentially identical patch was already submitted over here:
> 
> https://patchwork.kernel.org/patch/9493973/
> 
> I'm not sure how it ought to get into mainline - since the driver went through 
> the MIPS tree perhaps this fix can too?
> 

Do you know who should I ping about it? It has been posted a couple of months
ago.

> Thanks,
>     Paul
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches

[Paul Burton]

[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]

Hi Javier,

On Monday, 6 March 2017 10:09:09 PST Javier Martinez Canillas wrote:
> On 02/24/2017 06:56 PM, Paul Burton wrote:
> > On Monday, 20 February 2017 21:39:11 PST Dmitry Torokhov wrote:
> >> The OF device table must be terminated, otherwise we'll be walking past
> >> it and into areas unknown.
> >> 
> >> This causes KASAN errors reported by 0day kernel testing robot.
> >> 
> >> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> >> Tested-by: Fengguang Wu <fengguang.wu@intel.com>
> >> Fixes: 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple
> >> ASCII...") Cc: stable@vger.kernel.org
> >> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > 
> > An essentially identical patch was already submitted over here:
> > 
> > https://patchwork.kernel.org/patch/9493973/
> > 
> > I'm not sure how it ought to get into mainline - since the driver went
> > through the MIPS tree perhaps this fix can too?
> 
> Do you know who should I ping about it? It has been posted a couple of
> months ago.

If it can go through the MIPS tree that would be Ralf (who I copied 
previously). If not then it's Miguel as auxdisplay maintainer.

Thanks,
    Paul

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches

[Javier Martinez Canillas]

Hello Paul,

On 03/06/2017 03:54 PM, Paul Burton wrote:
> Hi Javier,
> 
> On Monday, 6 March 2017 10:09:09 PST Javier Martinez Canillas wrote:
>> On 02/24/2017 06:56 PM, Paul Burton wrote:
>>> On Monday, 20 February 2017 21:39:11 PST Dmitry Torokhov wrote:
>>>> The OF device table must be terminated, otherwise we'll be walking past
>>>> it and into areas unknown.
>>>>
>>>> This causes KASAN errors reported by 0day kernel testing robot.
>>>>
>>>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>>>> Tested-by: Fengguang Wu <fengguang.wu@intel.com>
>>>> Fixes: 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple
>>>> ASCII...") Cc: stable@vger.kernel.org
>>>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>>>
>>> An essentially identical patch was already submitted over here:
>>>
>>> https://patchwork.kernel.org/patch/9493973/
>>>
>>> I'm not sure how it ought to get into mainline - since the driver went
>>> through the MIPS tree perhaps this fix can too?
>>
>> Do you know who should I ping about it? It has been posted a couple of
>> months ago.
> 
> If it can go through the MIPS tree that would be Ralf (who I copied 
> previously). If not then it's Miguel as auxdisplay maintainer.
>

Ok, Thanks for your help. I just asked in case MAINTAINERS wasn't up-to-date
since the patches were posted a long time ago and had no feedback.
 
> Thanks,
>     Paul
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches

[Dmitry Torokhov]

On Mon, Mar 06, 2017 at 03:58:04PM -0300, Javier Martinez Canillas wrote:
> Hello Paul,
> 
> On 03/06/2017 03:54 PM, Paul Burton wrote:
> > Hi Javier,
> > 
> > On Monday, 6 March 2017 10:09:09 PST Javier Martinez Canillas wrote:
> >> On 02/24/2017 06:56 PM, Paul Burton wrote:
> >>> On Monday, 20 February 2017 21:39:11 PST Dmitry Torokhov wrote:
> >>>> The OF device table must be terminated, otherwise we'll be walking past
> >>>> it and into areas unknown.
> >>>>
> >>>> This causes KASAN errors reported by 0day kernel testing robot.
> >>>>
> >>>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> >>>> Tested-by: Fengguang Wu <fengguang.wu@intel.com>
> >>>> Fixes: 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple
> >>>> ASCII...") Cc: stable@vger.kernel.org
> >>>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> >>>
> >>> An essentially identical patch was already submitted over here:
> >>>
> >>> https://patchwork.kernel.org/patch/9493973/
> >>>
> >>> I'm not sure how it ought to get into mainline - since the driver went
> >>> through the MIPS tree perhaps this fix can too?
> >>
> >> Do you know who should I ping about it? It has been posted a couple of
> >> months ago.
> > 
> > If it can go through the MIPS tree that would be Ralf (who I copied 
> > previously). If not then it's Miguel as auxdisplay maintainer.
> >
> 
> Ok, Thanks for your help. I just asked in case MAINTAINERS wasn't up-to-date
> since the patches were posted a long time ago and had no feedback.

Maybe we could get akpm pick it up?

Thanks.

-- 
Dmitry

Re: [PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches

[Javier Martinez Canillas]

Hello Dmitry,

On 03/06/2017 04:40 PM, Dmitry Torokhov wrote:
> On Mon, Mar 06, 2017 at 03:58:04PM -0300, Javier Martinez Canillas wrote:
>> Hello Paul,
>>
>> On 03/06/2017 03:54 PM, Paul Burton wrote:
>>> Hi Javier,
>>>
>>> On Monday, 6 March 2017 10:09:09 PST Javier Martinez Canillas wrote:
>>>> On 02/24/2017 06:56 PM, Paul Burton wrote:
>>>>> On Monday, 20 February 2017 21:39:11 PST Dmitry Torokhov wrote:
>>>>>> The OF device table must be terminated, otherwise we'll be walking past
>>>>>> it and into areas unknown.
>>>>>>
>>>>>> This causes KASAN errors reported by 0day kernel testing robot.
>>>>>>
>>>>>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>>>>>> Tested-by: Fengguang Wu <fengguang.wu@intel.com>
>>>>>> Fixes: 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple
>>>>>> ASCII...") Cc: stable@vger.kernel.org
>>>>>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>>>>>
>>>>> An essentially identical patch was already submitted over here:
>>>>>
>>>>> https://patchwork.kernel.org/patch/9493973/
>>>>>
>>>>> I'm not sure how it ought to get into mainline - since the driver went
>>>>> through the MIPS tree perhaps this fix can too?
>>>>
>>>> Do you know who should I ping about it? It has been posted a couple of
>>>> months ago.
>>>
>>> If it can go through the MIPS tree that would be Ralf (who I copied 
>>> previously). If not then it's Miguel as auxdisplay maintainer.
>>>
>>
>> Ok, Thanks for your help. I just asked in case MAINTAINERS wasn't up-to-date
>> since the patches were posted a long time ago and had no feedback.
> 
> Maybe we could get akpm pick it up?
> 

Good idea, I'll re-send with akpm to cc so he can pick them.

> Thanks.
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America