* [PATCH] ASoC: fsl_asrc_dma: use correct direction enum type
@ 2017-04-20 6:36 Stefan Agner
2017-04-20 6:43 ` Nicolin Chen
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Agner @ 2017-04-20 6:36 UTC (permalink / raw)
To: timur, nicoleotsuka, Xiubo.Lee
Cc: fabio.estevam, lgirdwood, broonie, perex, tiwai, alsa-devel,
linux-kernel, Stefan Agner
The direction argument is of type enum dma_transfer_direction, and
not enum dma_data_direction. The enumeration values are the same
so this did not had an effect in practise.
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
sound/soc/fsl/fsl_asrc_dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_asrc_dma.c b/sound/soc/fsl/fsl_asrc_dma.c
index dc30d780f874..282d841840b1 100644
--- a/sound/soc/fsl/fsl_asrc_dma.c
+++ b/sound/soc/fsl/fsl_asrc_dma.c
@@ -76,7 +76,7 @@ static int fsl_asrc_dma_prepare_and_submit(struct snd_pcm_substream *substream)
pair->dma_chan[!dir], runtime->dma_addr,
snd_pcm_lib_buffer_bytes(substream),
snd_pcm_lib_period_bytes(substream),
- dir == OUT ? DMA_TO_DEVICE : DMA_FROM_DEVICE, flags);
+ dir == OUT ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM, flags);
if (!pair->desc[!dir]) {
dev_err(dev, "failed to prepare slave DMA for Front-End\n");
return -ENOMEM;
--
2.12.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: fsl_asrc_dma: use correct direction enum type
2017-04-20 6:36 [PATCH] ASoC: fsl_asrc_dma: use correct direction enum type Stefan Agner
@ 2017-04-20 6:43 ` Nicolin Chen
0 siblings, 0 replies; 2+ messages in thread
From: Nicolin Chen @ 2017-04-20 6:43 UTC (permalink / raw)
To: Stefan Agner
Cc: timur, Xiubo.Lee, fabio.estevam, lgirdwood, broonie, perex, tiwai,
alsa-devel, linux-kernel
On Wed, Apr 19, 2017 at 11:36:07PM -0700, Stefan Agner wrote:
> The direction argument is of type enum dma_transfer_direction, and
> not enum dma_data_direction. The enumeration values are the same
> so this did not had an effect in practise.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Thanks
> ---
> sound/soc/fsl/fsl_asrc_dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/fsl_asrc_dma.c b/sound/soc/fsl/fsl_asrc_dma.c
> index dc30d780f874..282d841840b1 100644
> --- a/sound/soc/fsl/fsl_asrc_dma.c
> +++ b/sound/soc/fsl/fsl_asrc_dma.c
> @@ -76,7 +76,7 @@ static int fsl_asrc_dma_prepare_and_submit(struct snd_pcm_substream *substream)
> pair->dma_chan[!dir], runtime->dma_addr,
> snd_pcm_lib_buffer_bytes(substream),
> snd_pcm_lib_period_bytes(substream),
> - dir == OUT ? DMA_TO_DEVICE : DMA_FROM_DEVICE, flags);
> + dir == OUT ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM, flags);
> if (!pair->desc[!dir]) {
> dev_err(dev, "failed to prepare slave DMA for Front-End\n");
> return -ENOMEM;
> --
> 2.12.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-20 6:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-20 6:36 [PATCH] ASoC: fsl_asrc_dma: use correct direction enum type Stefan Agner
2017-04-20 6:43 ` Nicolin Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox