From: Darren Hart <dvhart@infradead.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andy Shevchenko <andy@infradead.org>,
Hans de Goede <hdegoede@redhat.com>,
Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: INT33FE: add I2C dependency
Date: Fri, 21 Apr 2017 14:42:19 -0700 [thread overview]
Message-ID: <20170421214219.GB31650@fury> (raw)
In-Reply-To: <20170421210331.876697-1-arnd@arndb.de>
On Fri, Apr 21, 2017 at 11:03:13PM +0200, Arnd Bergmann wrote:
> When I2C is disabled, we get a link error:
>
> drivers/platform/built-in.o: In function `cht_int33fe_remove':
> intel_cht_int33fe.c:(.text+0x8ba): undefined reference to `i2c_unregister_device'
> drivers/platform/built-in.o: In function `cht_int33fe_probe':
> intel_cht_int33fe.c:(.text+0x9ec): undefined reference to `i2c_acpi_new_device'
> intel_cht_int33fe.c:(.text+0xa7a): undefined reference to `i2c_unregister_device'
>
> This adds a Kconfig dependency to ensure I2C is available to this
> driver.
>
> Fixes: 1cd706df8a9c ("platform/x86: Add Intel Cherry Trail ACPI INT33FE device driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks Arnd, Tobias submitted a fix a short time ago, it'll be in next tomorrow.
Thanks!
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2017-04-21 21:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 21:03 [PATCH] platform/x86: INT33FE: add I2C dependency Arnd Bergmann
2017-04-21 21:42 ` Darren Hart [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-04-20 12:51 [PATCH] platform/x86: INT33FE: add i2c dependency Tobias Regnery
2017-04-21 7:19 ` Hans de Goede
2017-04-21 21:41 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170421214219.GB31650@fury \
--to=dvhart@infradead.org \
--cc=andy@infradead.org \
--cc=arnd@arndb.de \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rajneesh.bhardwaj@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox