From: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Marcos Paulo de Souza <marcos.souza.org@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Bhumika Goyal <bhumirks@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
simran singhal <singhalsimran0@gmail.com>,
Tobias Klauser <tklauser@distanz.ch>,
Elise Lennion <elise.lennion@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] staging: rtl8192u: Fix sparse warning
Date: Sun, 23 Apr 2017 17:51:17 -0300 [thread overview]
Message-ID: <20170423205229.6347-1-marcos.souza.org@gmail.com> (raw)
Fix the following sparse warning:
rtl8192u/ieee80211/ieee80211_rx.c:1489:45: warning: incorrect type in assignment (different base types)
rtl8192u/ieee80211/ieee80211_rx.c:1489:45: expected restricted __le16 <noident>
rtl8192u/ieee80211/ieee80211_rx.c:1489:45: got unsigned short [unsigned] [usertype] <noident>
Since ac_params->tx_op_limit is already an __le16, we shouldn't convert it into cpu type.
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
Sorry, I don't have the hardware to test, so please review and tell me if I'm wrong in this one!
drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
index 5241c50..3a6a533 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
@@ -1486,7 +1486,7 @@ static int ieee80211_qos_convert_ac_to_parameters(struct
qos_param->flag[aci] =
(ac_params->aci_aifsn & 0x10) ? 0x01 : 0x00;
- qos_param->tx_op_limit[aci] = le16_to_cpu(ac_params->tx_op_limit);
+ qos_param->tx_op_limit[aci] = ac_params->tx_op_limit;
}
return 0;
}
--
2.9.3
next reply other threads:[~2017-04-23 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-23 20:51 Marcos Paulo de Souza [this message]
2017-04-28 10:29 ` [PATCH] staging: rtl8192u: Fix sparse warning Greg Kroah-Hartman
2017-04-28 10:52 ` Marcos Paulo de Souza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170423205229.6347-1-marcos.souza.org@gmail.com \
--to=marcos.souza.org@gmail.com \
--cc=arnd@arndb.de \
--cc=bhumirks@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=elise.lennion@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=singhalsimran0@gmail.com \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox