From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Julius Werner <jwerner@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Thierry Escande <thierry.escande@collabora.com>,
Dmitry Torokhov <dtor@chromium.org>,
Aaron Durbin <adurbin@chromium.org>
Subject: Re: [PATCH] firmware: google: memconsole: Adapt to new coreboot ring buffer format
Date: Sat, 29 Apr 2017 07:33:53 +0200 [thread overview]
Message-ID: <20170429053353.GA11491@kroah.com> (raw)
In-Reply-To: <CAODwPW9bJ=qX7L1uDBpnpV3RKHOxAurhF1=te2g54GGSJTAtBQ@mail.gmail.com>
On Fri, Apr 28, 2017 at 01:44:45PM -0700, Julius Werner wrote:
> > -------------------------8<--------------------------------------------
>
> That needs to go below the --- line, not above it.
>
>
> Really? git am --scissors seems to do the right thing for me this way...
Ah, never used that option before, it's not part of my normal workflow.
> Anyway, it was only an FYI, I'll just leave it out.
>
>
> When you say things like "in addition" and "finally", that implies that
> the code needs to be broken up into multiple patches. Rememeber, each
> patch only should ever do 1 thing.
>
>
> Well... all these things are required to make the new format work. But I can
> split them up further if you like.
Please do, makes it easier to review, right?
thanks,
greg k-h
prev parent reply other threads:[~2017-04-29 5:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 20:59 [PATCH] firmware: google: memconsole: Adapt to new coreboot ring buffer format Julius Werner
2017-04-28 7:14 ` Greg Kroah-Hartman
[not found] ` <CAODwPW9bJ=qX7L1uDBpnpV3RKHOxAurhF1=te2g54GGSJTAtBQ@mail.gmail.com>
2017-04-29 5:33 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170429053353.GA11491@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adurbin@chromium.org \
--cc=dtor@chromium.org \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.escande@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox