From: luca abeni <luca.abeni@santannapisa.it>
To: Xunlei Pang <xpang@redhat.com>
Cc: Xunlei Pang <xlpang@redhat.com>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@arm.com>, Ingo Molnar <mingo@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Luca Abeni <luca.abeni@unitn.it>
Subject: Re: [PATCH v2 2/3] sched/deadline: Throttle the task when missing its deadline
Date: Fri, 12 May 2017 22:58:09 +0200 [thread overview]
Message-ID: <20170512225809.7ad9fda3@nowhere> (raw)
In-Reply-To: <5915621B.8050606@redhat.com>
On Fri, 12 May 2017 15:19:55 +0800
Xunlei Pang <xpang@redhat.com> wrote:
[...]
> >> "As seen, enforcing that the total utilization is smaller than M
> >> does not guarantee that global EDF schedules the tasks without
> >> missing any deadline (in other words, global EDF is not an optimal
> >> scheduling algorithm). However, a total utilization smaller than M
> >> is enough to guarantee that non real-time tasks are not starved
> >> and that the tardiness of real-time tasks has an upper bound[12]
> >> (as previously noted). Different bounds on the maximum tardiness
> >> experienced by real-time tasks have been developed in various
> >> papers[13,14], but the theoretical result that is important for
> >> SCHED_DEADLINE is that if the total utilization is smaller or equal
> >> than M then the response times of the tasks are limited."
> >>
> >> Do you mean there is some tardiness allowed in theory(global EDF is
> >> not an optimal scheduling algorithm), thus missed deadline is
> >> allowed for global EDF?
> > Right.
> >
> > With the admission test currently used by the kernel (sum of
> > utilizations <= 1), tasks are guaranteed to have a tardiness smaller
> > than a theoretical maximum... But this theoretical maximum can be
> > larger than 0.
> >
> > If you want to strictly respect all of the deadlines, you need a
> > stricter admission test (for example, the one based on WCET_max
> > that is mentioned above).
>
> Understood.
>
> I think in Patch 3, it is still worthy to add the accounting in
> dl_runtime_exceeded(), to track the dl scheduling tardiness(after all
> tardiness is not a good thing) like: if
> (dl_time_before(dl_se->deadline, rq_clock(rq)) && dl_se->runtime > 0)
> ++dl_se->nr_underrun_sched;
>
> Maybe changing the name to use "nr_underrun_tardy" is better, large
> value does need our attention. What do you think?
I do not know, I never used statistics like these...
If there are enough people having a good usecase for these statistics,
it might be worth adding them, but I do not know other people's
opinions about this.
Luca
next prev parent reply other threads:[~2017-05-12 20:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 3:32 [PATCH v2 1/3] sched/deadline: Zero out positive runtime after throttling constrained tasks Xunlei Pang
2017-05-12 3:32 ` [PATCH v2 2/3] sched/deadline: Throttle the task when missing its deadline Xunlei Pang
2017-05-12 5:57 ` luca abeni
2017-05-12 6:53 ` Xunlei Pang
2017-05-12 7:01 ` luca abeni
2017-05-12 7:19 ` Xunlei Pang
2017-05-12 20:58 ` luca abeni [this message]
2017-05-15 3:50 ` Xunlei Pang
2017-05-12 3:32 ` [PATCH v2 3/3] sched/deadline: Add statistics to track runtime underruns Xunlei Pang
2017-05-15 4:07 ` [PATCH v2 1/3] sched/deadline: Zero out positive runtime after throttling constrained tasks Xunlei Pang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170512225809.7ad9fda3@nowhere \
--to=luca.abeni@santannapisa.it \
--cc=bristot@redhat.com \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@unitn.it \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=xlpang@redhat.com \
--cc=xpang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox