From: Andrew Lunn <andrew@lunn.ch>
To: Maciek Fijalkowski <macfij7@wp.pl>
Cc: mst@redhat.com, jasonwang@redhat.com,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses
Date: Mon, 15 May 2017 02:25:31 +0200 [thread overview]
Message-ID: <20170515002531.GG14058@lunn.ch> (raw)
In-Reply-To: <20170514175130.18664-2-macfij7@wp.pl>
On Sun, May 14, 2017 at 07:51:29PM +0200, Maciek Fijalkowski wrote:
> From: Maciej Fijalkowski <macfij7@wp.pl>
Hi Maciek
Please include some commit message, even if it is just the checkpatch
error you are fixing.
Please include the subsystem/driver you are patch in the subject line.
Also, your subject of Fix ERROR: makes it sound a lot worse than it
is.
net: virtio: Fix checkpatch error Complex macros should use ()
Also, you should at least compile test your change. It is clearly
wrong, as shown by 0-day.
Andrew
next prev parent reply other threads:[~2017-05-15 0:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-14 17:51 [PATCH 1/3] Fix ERROR: trailing statements should be on next line Maciek Fijalkowski
2017-05-14 17:51 ` [PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses Maciek Fijalkowski
2017-05-14 18:48 ` kbuild test robot
2017-05-15 0:25 ` Andrew Lunn [this message]
2017-05-15 2:56 ` Michael S. Tsirkin
2017-05-14 17:51 ` [PATCH 3/3] Fix ERROR: code indent should use tabs where possible Maciek Fijalkowski
2017-05-15 3:00 ` Michael S. Tsirkin
2017-05-15 2:58 ` [PATCH 1/3] Fix ERROR: trailing statements should be on next line Michael S. Tsirkin
2017-05-15 3:20 ` Alex Williamson
2017-05-15 14:25 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515002531.GG14058@lunn.ch \
--to=andrew@lunn.ch \
--cc=jasonwang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macfij7@wp.pl \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox