From: Shawn Guo <shawnguo@kernel.org>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Sascha Hauer <kernel@pengutronix.de>,
Stefan Agner <stefan@agner.ch>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
Chris Healy <Chris.Healy@zii.aero>,
Jeff White <Jeff.White@zii.aero>
Subject: Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device
Date: Thu, 25 May 2017 16:20:32 +0800 [thread overview]
Message-ID: <20170525082030.GB26102@dragon> (raw)
In-Reply-To: <eb86f383-3c27-2276-6213-99c5143420f5@cogentembedded.com>
On Thu, May 25, 2017 at 11:06:47AM +0300, Nikita Yushchenko wrote:
> >> +&edma1 {
> >> + status = "okay";
> >> +};
> >> +
> >> +&dspi2 {
> >
> > Please keep these labelled nodes sort alphabetically.
>
> Ok
>
> >> + bus-num = <1>;
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&pinctrl_dspi2>;
> >> + status = "okay";
> >
> > We usually have 'status' line at the bottom of property list.
>
> Ok
>
> >> + spi-num-chipselects = <2>;
> >> +
> >> + hi8435@1 {
> >
> > Node name should be something generic, while label can be specific
> > model name. The following form might be better.
> >
> > hi8435: sensor@1
>
> Ok
>
> Although the same file, in lines nearby, has m25p128@0 and at93c46d@1.
It seems that I need more eyes to help review.
Shawn
prev parent reply other threads:[~2017-05-25 8:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 13:10 [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device Nikita Yushchenko
2017-05-22 16:20 ` Stefan Agner
2017-05-22 16:29 ` Nikita Yushchenko
2017-05-22 18:21 ` Andrew Lunn
2017-05-23 6:02 ` Nikita Yushchenko
2017-05-25 7:19 ` Shawn Guo
2017-05-25 8:03 ` Nikita Yushchenko
2017-05-28 15:09 ` Jonathan Cameron
2017-05-25 7:00 ` Shawn Guo
2017-05-25 8:06 ` Nikita Yushchenko
2017-05-25 8:20 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525082030.GB26102@dragon \
--to=shawnguo@kernel.org \
--cc=Chris.Healy@zii.aero \
--cc=Jeff.White@zii.aero \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=nikita.yoush@cogentembedded.com \
--cc=robh+dt@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox