* [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc static
@ 2017-07-10 18:51 Colin King
2017-07-11 17:54 ` Andrey Utkin
2017-07-11 18:56 ` Ismael Luceno
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2017-07-10 18:51 UTC (permalink / raw)
To: Bluecherry Maintainers, Anton Sviridenko, Andrey Utkin,
Ismael Luceno, Mauro Carvalho Chehab, linux-media
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Don't populate const array saa7128_regs_ntsc on the stack but insteaed make
it static. Makes the object code smaller and saves nearly 840 bytes
Before:
text data bss dec hex filename
9218 360 0 9578 256a solo6x10-tw28.o
After:
text data bss dec hex filename
8237 504 0 8741 2225 solo6x10-tw28.o
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/media/pci/solo6x10/solo6x10-tw28.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/solo6x10/solo6x10-tw28.c b/drivers/media/pci/solo6x10/solo6x10-tw28.c
index 0632d3f7c73c..1c013a03d851 100644
--- a/drivers/media/pci/solo6x10/solo6x10-tw28.c
+++ b/drivers/media/pci/solo6x10/solo6x10-tw28.c
@@ -532,7 +532,7 @@ static void saa712x_write_regs(struct solo_dev *dev, const u8 *vals,
static void saa712x_setup(struct solo_dev *dev)
{
const int reg_start = 0x26;
- const u8 saa7128_regs_ntsc[] = {
+ static const u8 saa7128_regs_ntsc[] = {
/* :0x26 */
0x0d, 0x00,
/* :0x28 */
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc static
2017-07-10 18:51 [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc static Colin King
@ 2017-07-11 17:54 ` Andrey Utkin
2017-07-11 18:56 ` Ismael Luceno
1 sibling, 0 replies; 3+ messages in thread
From: Andrey Utkin @ 2017-07-11 17:54 UTC (permalink / raw)
To: Colin King
Cc: Bluecherry Maintainers, Anton Sviridenko, Andrey Utkin,
Ismael Luceno, Mauro Carvalho Chehab, linux-media,
kernel-janitors, linux-kernel
On Mon, Jul 10, 2017 at 07:51:03PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate const array saa7128_regs_ntsc on the stack but insteaed make
> it static. Makes the object code smaller and saves nearly 840 bytes
>
> Before:
> text data bss dec hex filename
> 9218 360 0 9578 256a solo6x10-tw28.o
>
> After:
> text data bss dec hex filename
> 8237 504 0 8741 2225 solo6x10-tw28.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Andrey Utkin <andrey_utkin@fastmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc static
2017-07-10 18:51 [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc static Colin King
2017-07-11 17:54 ` Andrey Utkin
@ 2017-07-11 18:56 ` Ismael Luceno
1 sibling, 0 replies; 3+ messages in thread
From: Ismael Luceno @ 2017-07-11 18:56 UTC (permalink / raw)
To: Colin King
Cc: Bluecherry Maintainers, Anton Sviridenko, Andrey Utkin,
Mauro Carvalho Chehab, linux-media, kernel-janitors, linux-kernel
On 10/Jul/2017 19:51, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate const array saa7128_regs_ntsc on the stack but insteaed make
> it static. Makes the object code smaller and saves nearly 840 bytes
>
> Before:
> text data bss dec hex filename
> 9218 360 0 9578 256a solo6x10-tw28.o
>
> After:
> text data bss dec hex filename
> 8237 504 0 8741 2225 solo6x10-tw28.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/media/pci/solo6x10/solo6x10-tw28.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/solo6x10/solo6x10-tw28.c b/drivers/media/pci/solo6x10/solo6x10-tw28.c
> index 0632d3f7c73c..1c013a03d851 100644
> --- a/drivers/media/pci/solo6x10/solo6x10-tw28.c
> +++ b/drivers/media/pci/solo6x10/solo6x10-tw28.c
> @@ -532,7 +532,7 @@ static void saa712x_write_regs(struct solo_dev *dev, const u8 *vals,
> static void saa712x_setup(struct solo_dev *dev)
> {
> const int reg_start = 0x26;
> - const u8 saa7128_regs_ntsc[] = {
> + static const u8 saa7128_regs_ntsc[] = {
> /* :0x26 */
> 0x0d, 0x00,
> /* :0x28 */
Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-11 19:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-10 18:51 [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc static Colin King
2017-07-11 17:54 ` Andrey Utkin
2017-07-11 18:56 ` Ismael Luceno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox