From: Greg KH <gregkh@linuxfoundation.org>
To: Juergen Gross <jgross@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xen: xen-pciback: remove DRIVER_ATTR() usage
Date: Wed, 19 Jul 2017 17:17:21 +0200 [thread overview]
Message-ID: <20170719151721.GA31932@kroah.com> (raw)
In-Reply-To: <d47a6490-a06f-aca1-3392-a12149471ecc@suse.com>
On Wed, Jul 19, 2017 at 04:51:02PM +0200, Juergen Gross wrote:
> On 19/07/17 16:43, Greg KH wrote:
> > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > It's better to be explicit and use the DRIVER_ATTR_RW() and
> > DRIVER_ATTR_RO() macros when defining a driver's sysfs file.
> >
> > Bonus is this fixes up a checkpatch.pl warning.
> >
> > This is part of a series to drop DRIVER_ATTR() from the tree entirely.
> >
> > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> > Cc: Juergen Gross <jgross@suse.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
>
> I'll take this through the Xen tree, unless you want to use your tree.
If I can take it through mine, then I could drop DRIVER_ATTR() from the
whole tree for the next kernel release, which would be ideal.
But if you want to take it, that's fine, I can wait another release, no
rush.
thanks,
greg k-h
next prev parent reply other threads:[~2017-07-19 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 12:58 [PATCH] xen: xen-pciback: remove DRIVER_ATTR() usage Greg KH
2017-07-19 13:17 ` Juergen Gross
2017-07-19 14:22 ` Greg KH
2017-07-19 14:43 ` [PATCH v2] " Greg KH
2017-07-19 14:51 ` Juergen Gross
2017-07-19 15:17 ` Greg KH [this message]
2017-07-19 17:20 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170719151721.GA31932@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox