The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Nadav Amit <namit@vmware.com>
Cc: Mel Gorman <mgorman@suse.de>, Rik van Riel <riel@redhat.com>,
	Andy Lutomirski <luto@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Michal Hocko <mhocko@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: [mmots] build error: mm: prevent racy access to tlb_flush_pending
Date: Thu, 27 Jul 2017 21:32:28 +0900	[thread overview]
Message-ID: <20170727123228.GA573@tigerII.localdomain> (raw)

Hello,

8c636138f497b36ae95f ("mm: prevent racy access to tlb_flush_pending") kills
the build

kernel/fork.c: In function ‘mm_init’:
kernel/fork.c:810:18: error: ‘struct mm_struct’ has no member named ‘tlb_flush_pending’; did you mean ‘tlb_flush_batched’?
  atomic_set(&mm->tlb_flush_pending, 0);
                  ^~~~~~~~~~~~~~~~~
                  tlb_flush_batched



replacing clear_tlb_flush_pending() with a direct ->tlb_flush_pending
access

@@ -807,7 +807,7 @@ static struct mm_struct *mm_init(struct mm_struct *mm, struct task_struct *p,
        mm_init_aio(mm);
        mm_init_owner(mm, p);
        mmu_notifier_mm_init(mm);
-       clear_tlb_flush_pending(mm);
+       atomic_set(&mm->tlb_flush_pending, 0);


doesn't work on on !CONFIG_NUMA_BALANCING && !CONFIG_COMPACTION systems.

	-ss

             reply	other threads:[~2017-07-27 12:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-27 12:32 Sergey Senozhatsky [this message]
2017-07-27 15:18 ` [mmots] build error: mm: prevent racy access to tlb_flush_pending Nadav Amit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170727123228.GA573@tigerII.localdomain \
    --to=sergey.senozhatsky@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@kernel.org \
    --cc=namit@vmware.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox