* [mmots] build error: mm: prevent racy access to tlb_flush_pending
@ 2017-07-27 12:32 Sergey Senozhatsky
2017-07-27 15:18 ` Nadav Amit
0 siblings, 1 reply; 2+ messages in thread
From: Sergey Senozhatsky @ 2017-07-27 12:32 UTC (permalink / raw)
To: Nadav Amit
Cc: Mel Gorman, Rik van Riel, Andy Lutomirski, Andrew Morton,
Michal Hocko, linux-kernel
Hello,
8c636138f497b36ae95f ("mm: prevent racy access to tlb_flush_pending") kills
the build
kernel/fork.c: In function ‘mm_init’:
kernel/fork.c:810:18: error: ‘struct mm_struct’ has no member named ‘tlb_flush_pending’; did you mean ‘tlb_flush_batched’?
atomic_set(&mm->tlb_flush_pending, 0);
^~~~~~~~~~~~~~~~~
tlb_flush_batched
replacing clear_tlb_flush_pending() with a direct ->tlb_flush_pending
access
@@ -807,7 +807,7 @@ static struct mm_struct *mm_init(struct mm_struct *mm, struct task_struct *p,
mm_init_aio(mm);
mm_init_owner(mm, p);
mmu_notifier_mm_init(mm);
- clear_tlb_flush_pending(mm);
+ atomic_set(&mm->tlb_flush_pending, 0);
doesn't work on on !CONFIG_NUMA_BALANCING && !CONFIG_COMPACTION systems.
-ss
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [mmots] build error: mm: prevent racy access to tlb_flush_pending
2017-07-27 12:32 [mmots] build error: mm: prevent racy access to tlb_flush_pending Sergey Senozhatsky
@ 2017-07-27 15:18 ` Nadav Amit
0 siblings, 0 replies; 2+ messages in thread
From: Nadav Amit @ 2017-07-27 15:18 UTC (permalink / raw)
To: Sergey Senozhatsky, Minchan Kim
Cc: Mel Gorman, Rik van Riel, Andy Lutomirski, Andrew Morton,
Michal Hocko, LKML
Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:
> Hello,
>
> 8c636138f497b36ae95f ("mm: prevent racy access to tlb_flush_pending") kills
> the build
>
> kernel/fork.c: In function ‘mm_init’:
> kernel/fork.c:810:18: error: ‘struct mm_struct’ has no member named ‘tlb_flush_pending’; did you mean ‘tlb_flush_batched’?
> atomic_set(&mm->tlb_flush_pending, 0);
> ^~~~~~~~~~~~~~~~~
> tlb_flush_batched
>
>
>
> replacing clear_tlb_flush_pending() with a direct ->tlb_flush_pending
> access
>
> @@ -807,7 +807,7 @@ static struct mm_struct *mm_init(struct mm_struct *mm, struct task_struct *p,
> mm_init_aio(mm);
> mm_init_owner(mm, p);
> mmu_notifier_mm_init(mm);
> - clear_tlb_flush_pending(mm);
> + atomic_set(&mm->tlb_flush_pending, 0);
>
>
> doesn't work on on !CONFIG_NUMA_BALANCING && !CONFIG_COMPACTION systems.
>
> -ss
Missed this one. Thanks, I will fix it for v3.
When Minchan repurpose this field, he should remove all of these defines
(including those in mm_types.h).
Minchan, do you want me to do it?
Nadav
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-27 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-27 12:32 [mmots] build error: mm: prevent racy access to tlb_flush_pending Sergey Senozhatsky
2017-07-27 15:18 ` Nadav Amit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox