[PATCH] mux: include compiler.h from mux/consumer.h

[PATCH] mux: include compiler.h from mux/consumer.h

[Peter Rosin]

From: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>

Required for __must_check.

Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Signed-off-by: Peter Rosin <peda@axentia.se>
---
 include/linux/mux/consumer.h | 2 ++
 1 file changed, 2 insertions(+)

Hi Greg,

Please pick this up for 4.14.

Cheers,
Peter

diff --git a/include/linux/mux/consumer.h b/include/linux/mux/consumer.h
index 5577e1b773c4..ea96d4c82be7 100644
--- a/include/linux/mux/consumer.h
+++ b/include/linux/mux/consumer.h
@@ -13,6 +13,8 @@
 #ifndef _LINUX_MUX_CONSUMER_H
 #define _LINUX_MUX_CONSUMER_H
 
+#include <linux/compiler.h>
+
 struct device;
 struct mux_control;
 
-- 
2.11.0

Re: [PATCH] mux: include compiler.h from mux/consumer.h

[Greg Kroah-Hartman]

On Mon, Jul 31, 2017 at 12:04:35PM +0200, Peter Rosin wrote:
> From: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> 
> Required for __must_check.
> 
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
>  include/linux/mux/consumer.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> Hi Greg,
> 
> Please pick this up for 4.14.

What commit is this patch fixing?

thanks,

greg k-h

Re: [PATCH] mux: include compiler.h from mux/consumer.h

[Peter Rosin]

On 2017-07-31 18:00, Greg Kroah-Hartman wrote:
> On Mon, Jul 31, 2017 at 12:04:35PM +0200, Peter Rosin wrote:
>> From: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
>>
>> Required for __must_check.
>>
>> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
>> Signed-off-by: Peter Rosin <peda@axentia.se>
>> ---
>>  include/linux/mux/consumer.h | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> Hi Greg,
>>
>> Please pick this up for 4.14.
> 
> What commit is this patch fixing?

I don't think it's needed for any existing user, I at least do not have any
report about that. So, I don't think it's needed for stable.

Ulrich, the way I understood this, it was needed for your serdev series [1],
and not for any existing usage. Right?

If I misunderstood, it would be

Fixes: a3b02a9c6591 ("mux: minimal mux subsystem")

Cheers,
Peter

[1] https://www.spinics.net/lists/linux-i2c/msg30475.html

Re: [PATCH] mux: include compiler.h from mux/consumer.h

[Ulrich Hecht]

On Mon, Jul 31, 2017 at 6:28 PM, Peter Rosin <peda@axentia.se> wrote:
> On 2017-07-31 18:00, Greg Kroah-Hartman wrote:
>> On Mon, Jul 31, 2017 at 12:04:35PM +0200, Peter Rosin wrote:
>>> From: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
>>>
>>> Required for __must_check.
>>>
>>> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
>>> Signed-off-by: Peter Rosin <peda@axentia.se>
>>> ---
>>>  include/linux/mux/consumer.h | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> Hi Greg,
>>>
>>> Please pick this up for 4.14.
>>
>> What commit is this patch fixing?
>
> I don't think it's needed for any existing user, I at least do not have any
> report about that. So, I don't think it's needed for stable.
>
> Ulrich, the way I understood this, it was needed for your serdev series [1],
> and not for any existing usage. Right?

That is correct.

CU
Uli