public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, noralf@tronnes.org,
	Eric Anholt <eric@anholt.net>
Subject: [PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI.
Date: Wed,  2 Aug 2017 13:32:42 -0700	[thread overview]
Message-ID: <20170802203242.12815-3-eric@anholt.net> (raw)
In-Reply-To: <20170802203242.12815-1-eric@anholt.net>

drm_bridge_remove() is for unregistering a bridge driver, not for
detaching a bridge from its consumer.

Fixes: 656fa22f9cea ("drm/vc4: Switch DSI to the panel-bridge layer, and support bridges.")
Signed-off-by: Eric Anholt <eric@anholt.net>
---
 drivers/gpu/drm/vc4/vc4_dsi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
index 13481bb6322f..d1e0dc908048 100644
--- a/drivers/gpu/drm/vc4/vc4_dsi.c
+++ b/drivers/gpu/drm/vc4/vc4_dsi.c
@@ -1636,7 +1636,6 @@ static void vc4_dsi_unbind(struct device *dev, struct device *master,
 
 	pm_runtime_disable(dev);
 
-	drm_bridge_remove(dsi->bridge);
 	vc4_dsi_encoder_destroy(dsi->encoder);
 
 	mipi_dsi_host_unregister(&dsi->dsi_host);
-- 
2.13.3

  parent reply	other threads:[~2017-08-02 20:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-02 20:32 [PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown Eric Anholt
2017-08-02 20:32 ` [PATCH 2/3] drm/vc4: Don't disable DSI clocks on component unload Eric Anholt
2017-08-03 13:37   ` Noralf Trønnes
2017-08-04 10:02   ` Boris Brezillon
2017-08-02 20:32 ` Eric Anholt [this message]
2017-08-03 13:37   ` [PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI Noralf Trønnes
2017-08-04 10:08   ` Boris Brezillon
2017-08-02 20:53 ` [PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown Noralf Trønnes
2017-08-04 10:01 ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170802203242.12815-3-eric@anholt.net \
    --to=eric@anholt.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noralf@tronnes.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox