From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Eric Anholt <eric@anholt.net>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] drm/vc4: Don't disable DSI clocks on component unload.
Date: Fri, 4 Aug 2017 12:02:41 +0200 [thread overview]
Message-ID: <20170804120241.3fe6889a@bbrezillon> (raw)
In-Reply-To: <20170802203242.12815-2-eric@anholt.net>
On Wed, 2 Aug 2017 13:32:41 -0700
Eric Anholt <eric@anholt.net> wrote:
> The clocks are enabled/disabled at encoder enable/disable time, not at
> component load. Fixes a WARN_ON at boot if V3D fails to probe.
>
> Fixes: 4078f5757144 ("drm/vc4: Add DSI driver")
> Signed-off-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> drivers/gpu/drm/vc4/vc4_dsi.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
> index 629d372633e6..13481bb6322f 100644
> --- a/drivers/gpu/drm/vc4/vc4_dsi.c
> +++ b/drivers/gpu/drm/vc4/vc4_dsi.c
> @@ -1641,9 +1641,6 @@ static void vc4_dsi_unbind(struct device *dev, struct device *master,
>
> mipi_dsi_host_unregister(&dsi->dsi_host);
>
> - clk_disable_unprepare(dsi->pll_phy_clock);
> - clk_disable_unprepare(dsi->escape_clock);
> -
> if (dsi->port == 1)
> vc4->dsi1 = NULL;
> }
next prev parent reply other threads:[~2017-08-04 10:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 20:32 [PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown Eric Anholt
2017-08-02 20:32 ` [PATCH 2/3] drm/vc4: Don't disable DSI clocks on component unload Eric Anholt
2017-08-03 13:37 ` Noralf Trønnes
2017-08-04 10:02 ` Boris Brezillon [this message]
2017-08-02 20:32 ` [PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI Eric Anholt
2017-08-03 13:37 ` Noralf Trønnes
2017-08-04 10:08 ` Boris Brezillon
2017-08-02 20:53 ` [PATCH 1/3] drm/vc4: Fix double destroy of the BO cache on teardown Noralf Trønnes
2017-08-04 10:01 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170804120241.3fe6889a@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox