* [PATCH] platform/x86: intel_mid_powerbtn: fix error return code in mid_pb_probe()
@ 2017-08-09 16:00 Gustavo A. R. Silva
2017-08-13 12:30 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2017-08-09 16:00 UTC (permalink / raw)
To: Darren Hart, Andy Shevchenko
Cc: platform-driver-x86, linux-kernel, Gustavo A. R. Silva
platform_get_irq() returns an error code, but the intel_mid_powerbtn
driver ignores it and always returns -EINVAL. This is not correct and,
prevents -EPROBE_DEFER from being propagated properly.
Print error message and propagate the return value of platform_get_irq
on failure.
This issue was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/platform/x86/intel_mid_powerbtn.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/intel_mid_powerbtn.c b/drivers/platform/x86/intel_mid_powerbtn.c
index 871cfa6..854a16d 100644
--- a/drivers/platform/x86/intel_mid_powerbtn.c
+++ b/drivers/platform/x86/intel_mid_powerbtn.c
@@ -142,8 +142,10 @@ static int mid_pb_probe(struct platform_device *pdev)
if (!id)
return -ENODEV;
- if (irq < 0)
- return -EINVAL;
+ if (irq < 0) {
+ dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq);
+ return irq;
+ }
input = devm_input_allocate_device(&pdev->dev);
if (!input)
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] platform/x86: intel_mid_powerbtn: fix error return code in mid_pb_probe()
2017-08-09 16:00 [PATCH] platform/x86: intel_mid_powerbtn: fix error return code in mid_pb_probe() Gustavo A. R. Silva
@ 2017-08-13 12:30 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2017-08-13 12:30 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Darren Hart, Andy Shevchenko, Platform Driver,
linux-kernel@vger.kernel.org
On Wed, Aug 9, 2017 at 7:00 PM, Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
> platform_get_irq() returns an error code, but the intel_mid_powerbtn
> driver ignores it and always returns -EINVAL. This is not correct and,
> prevents -EPROBE_DEFER from being propagated properly.
>
> Print error message and propagate the return value of platform_get_irq
> on failure.
>
> This issue was detected with the help of Coccinelle.
Pushed to testing, thanks!
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/platform/x86/intel_mid_powerbtn.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/intel_mid_powerbtn.c b/drivers/platform/x86/intel_mid_powerbtn.c
> index 871cfa6..854a16d 100644
> --- a/drivers/platform/x86/intel_mid_powerbtn.c
> +++ b/drivers/platform/x86/intel_mid_powerbtn.c
> @@ -142,8 +142,10 @@ static int mid_pb_probe(struct platform_device *pdev)
> if (!id)
> return -ENODEV;
>
> - if (irq < 0)
> - return -EINVAL;
> + if (irq < 0) {
> + dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq);
> + return irq;
> + }
>
> input = devm_input_allocate_device(&pdev->dev);
> if (!input)
> --
> 2.5.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-13 12:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-09 16:00 [PATCH] platform/x86: intel_mid_powerbtn: fix error return code in mid_pb_probe() Gustavo A. R. Silva
2017-08-13 12:30 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox