public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: 张树荣 <marvinzhang.kernel@gmail.com>
Cc: Jens Frederich <jfrederich@gmail.com>,
	Daniel Drake <dsd@laptop.org>,
	Jon Nettleton <jon.nettleton@gmail.com>,
	devel <devel@driverdev.osuosl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: olpc_dcon: Fix coding style issue caught bycheckpatch.pl related to function name in debug print
Date: Thu, 17 Aug 2017 11:01:42 -0700	[thread overview]
Message-ID: <20170817180142.GE5980@kroah.com> (raw)
In-Reply-To: <CAOP-VhnxtWvgf-E8=1O8=YdpecF+-pWJ-gvHOZgBwtK9nAMOcQ@mail.gmail.com>

On Sun, Aug 06, 2017 at 12:12:47AM +0800, 张树荣 wrote:
> Replace hard-coded function names in strings with "%s", __func__
>     in the olpc_dcon.c file. Issue found by checkpatch.pl.

Your subject line is too long :(

> 
> Signed-off-by: Marvin Zhang <MarvinZhang.kernel@gmail.com>
> ---
>  drivers/staging/olpc_dcon/olpc_dcon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c
> b/drivers/staging/olpc_dcon/olpc_dcon.c
> index f7f3a78..429ca58 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -456,7 +456,7 @@ static ssize_t dcon_freeze_store(struct device *dev,
>   if (ret)
>   return ret;
> 
> - pr_info("dcon_freeze_store: %lu\n", output);
> + pr_info("%s: %lu\n",__func__, output);

Your patch is corrupted and can not be applied :(

Please fix up and resend.

thanks,

greg k-h

      reply	other threads:[~2017-08-17 18:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-05 16:12 [PATCH] staging: olpc_dcon: Fix coding style issue caught bycheckpatch.pl related to function name in debug print 张树荣
2017-08-17 18:01 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170817180142.GE5980@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=dsd@laptop.org \
    --cc=jfrederich@gmail.com \
    --cc=jon.nettleton@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marvinzhang.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox