* [PATCH v2] Staging: ccree: Prefer using BIT macro.
@ 2017-09-07 14:14 Srishti Sharma
2017-09-11 16:24 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Srishti Sharma @ 2017-09-07 14:14 UTC (permalink / raw)
To: gilad
Cc: gregkh, linux-crypto, driverdev-devel, devel, linux-kernel,
outreachy-kernel, Srishti Sharma
Use BIT(x) instead of using (1<<x), reported by checkpatch.pl.
Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
---
Changes in v2:
- Add tab spaces before BIT macro.
drivers/staging/ccree/ssi_cipher.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.h b/drivers/staging/ccree/ssi_cipher.h
index 296b375..c9a83df 100644
--- a/drivers/staging/ccree/ssi_cipher.h
+++ b/drivers/staging/ccree/ssi_cipher.h
@@ -27,11 +27,11 @@
#include "ssi_buffer_mgr.h"
/* Crypto cipher flags */
-#define CC_CRYPTO_CIPHER_KEY_KFDE0 (1 << 0)
-#define CC_CRYPTO_CIPHER_KEY_KFDE1 (1 << 1)
-#define CC_CRYPTO_CIPHER_KEY_KFDE2 (1 << 2)
-#define CC_CRYPTO_CIPHER_KEY_KFDE3 (1 << 3)
-#define CC_CRYPTO_CIPHER_DU_SIZE_512B (1 << 4)
+#define CC_CRYPTO_CIPHER_KEY_KFDE0 BIT(0)
+#define CC_CRYPTO_CIPHER_KEY_KFDE1 BIT(1)
+#define CC_CRYPTO_CIPHER_KEY_KFDE2 BIT(2)
+#define CC_CRYPTO_CIPHER_KEY_KFDE3 BIT(3)
+#define CC_CRYPTO_CIPHER_DU_SIZE_512B BIT(4)
#define CC_CRYPTO_CIPHER_KEY_KFDE_MASK (CC_CRYPTO_CIPHER_KEY_KFDE0 | CC_CRYPTO_CIPHER_KEY_KFDE1 | CC_CRYPTO_CIPHER_KEY_KFDE2 | CC_CRYPTO_CIPHER_KEY_KFDE3)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Staging: ccree: Prefer using BIT macro.
2017-09-07 14:14 [PATCH v2] Staging: ccree: Prefer using BIT macro Srishti Sharma
@ 2017-09-11 16:24 ` Greg KH
2017-09-11 17:17 ` Srishti Sharma
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2017-09-11 16:24 UTC (permalink / raw)
To: Srishti Sharma
Cc: gilad, devel, driverdev-devel, linux-kernel, outreachy-kernel,
linux-crypto
On Thu, Sep 07, 2017 at 07:44:52PM +0530, Srishti Sharma wrote:
> Use BIT(x) instead of using (1<<x), reported by checkpatch.pl.
>
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
> ---
> Changes in v2:
> - Add tab spaces before BIT macro.
>
> drivers/staging/ccree/ssi_cipher.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
This change is already in my tree from someone else, sorry.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Staging: ccree: Prefer using BIT macro.
2017-09-11 16:24 ` Greg KH
@ 2017-09-11 17:17 ` Srishti Sharma
0 siblings, 0 replies; 3+ messages in thread
From: Srishti Sharma @ 2017-09-11 17:17 UTC (permalink / raw)
To: Greg KH
Cc: Gilad Ben-Yossef, devel, driverdev-devel,
Linux kernel mailing list, outreachy-kernel,
Linux Crypto Mailing List
On Mon, Sep 11, 2017 at 9:54 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, Sep 07, 2017 at 07:44:52PM +0530, Srishti Sharma wrote:
>> Use BIT(x) instead of using (1<<x), reported by checkpatch.pl.
>>
>> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
>> ---
>> Changes in v2:
>> - Add tab spaces before BIT macro.
>>
>> drivers/staging/ccree/ssi_cipher.h | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> This change is already in my tree from someone else, sorry.
Oh.. It's okay !
Thanks,
Srishti
>
> greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-11 17:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-07 14:14 [PATCH v2] Staging: ccree: Prefer using BIT macro Srishti Sharma
2017-09-11 16:24 ` Greg KH
2017-09-11 17:17 ` Srishti Sharma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox