* [PATCH] arch_topology: Fix section miss match warning due to free_raw_capacity()
@ 2017-09-25 22:51 Prasad Sodagudi
2017-09-25 23:20 ` Viresh Kumar
0 siblings, 1 reply; 4+ messages in thread
From: Prasad Sodagudi @ 2017-09-25 22:51 UTC (permalink / raw)
To: gregkh, viresh.kumar, juri.lelli; +Cc: psodagud, linux-kernel
Remove the __init annotation from free_raw_capacity() to avoid
the following warning.
The function init_cpu_capacity_callback() references the
function __init free_raw_capacity().
WARNING: vmlinux.o(.text+0x425cc0): Section mismatch in reference
from the function init_cpu_capacity_callback() to the function
.init.text:free_raw_capacity().
Signed-off-by: Prasad Sodagudi <psodagud@codeaurora.org>
---
drivers/base/arch_topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
index 41be9ff..3da53cc 100644
--- a/drivers/base/arch_topology.c
+++ b/drivers/base/arch_topology.c
@@ -96,7 +96,7 @@ static int register_cpu_capacity_sysctl(void)
static u32 capacity_scale;
static u32 *raw_capacity;
-static int __init free_raw_capacity(void)
+static int free_raw_capacity(void)
{
kfree(raw_capacity);
raw_capacity = NULL;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arch_topology: Fix section miss match warning due to free_raw_capacity()
2017-09-25 22:51 [PATCH] arch_topology: Fix section miss match warning due to free_raw_capacity() Prasad Sodagudi
@ 2017-09-25 23:20 ` Viresh Kumar
2017-10-06 1:40 ` Sodagudi Prasad
2017-10-10 7:34 ` Prasad Sodagudi
0 siblings, 2 replies; 4+ messages in thread
From: Viresh Kumar @ 2017-09-25 23:20 UTC (permalink / raw)
To: Prasad Sodagudi; +Cc: gregkh, juri.lelli, linux-kernel
On 25-09-17, 15:51, Prasad Sodagudi wrote:
> Remove the __init annotation from free_raw_capacity() to avoid
> the following warning.
>
> The function init_cpu_capacity_callback() references the
> function __init free_raw_capacity().
> WARNING: vmlinux.o(.text+0x425cc0): Section mismatch in reference
> from the function init_cpu_capacity_callback() to the function
> .init.text:free_raw_capacity().
>
> Signed-off-by: Prasad Sodagudi <psodagud@codeaurora.org>
> ---
> drivers/base/arch_topology.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
> index 41be9ff..3da53cc 100644
> --- a/drivers/base/arch_topology.c
> +++ b/drivers/base/arch_topology.c
> @@ -96,7 +96,7 @@ static int register_cpu_capacity_sysctl(void)
> static u32 capacity_scale;
> static u32 *raw_capacity;
>
> -static int __init free_raw_capacity(void)
> +static int free_raw_capacity(void)
> {
> kfree(raw_capacity);
> raw_capacity = NULL;
So we need the __init thing only when cpufreq support isn't there in the kernel
and I am not sure if we want to add more ifdef hackery in the declaration of
free_raw_capacity().
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arch_topology: Fix section miss match warning due to free_raw_capacity()
2017-09-25 23:20 ` Viresh Kumar
@ 2017-10-06 1:40 ` Sodagudi Prasad
2017-10-10 7:34 ` Prasad Sodagudi
1 sibling, 0 replies; 4+ messages in thread
From: Sodagudi Prasad @ 2017-10-06 1:40 UTC (permalink / raw)
To: Viresh Kumar, gregkh; +Cc: gregkh, juri.lelli, linux-kernel
On 2017-09-25 16:20, Viresh Kumar wrote:
> On 25-09-17, 15:51, Prasad Sodagudi wrote:
>> Remove the __init annotation from free_raw_capacity() to avoid
>> the following warning.
>>
>> The function init_cpu_capacity_callback() references the
>> function __init free_raw_capacity().
>> WARNING: vmlinux.o(.text+0x425cc0): Section mismatch in reference
>> from the function init_cpu_capacity_callback() to the function
>> .init.text:free_raw_capacity().
>>
>> Signed-off-by: Prasad Sodagudi <psodagud@codeaurora.org>
>> ---
>> drivers/base/arch_topology.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/base/arch_topology.c
>> b/drivers/base/arch_topology.c
>> index 41be9ff..3da53cc 100644
>> --- a/drivers/base/arch_topology.c
>> +++ b/drivers/base/arch_topology.c
>> @@ -96,7 +96,7 @@ static int register_cpu_capacity_sysctl(void)
>> static u32 capacity_scale;
>> static u32 *raw_capacity;
>>
>> -static int __init free_raw_capacity(void)
>> +static int free_raw_capacity(void)
>> {
>> kfree(raw_capacity);
>> raw_capacity = NULL;
>
> So we need the __init thing only when cpufreq support isn't there in
> the kernel
> and I am not sure if we want to add more ifdef hackery in the
> declaration of
> free_raw_capacity().
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Hi Greg,
Can you please consider this patch ?
-Thanks, Prasad
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] arch_topology: Fix section miss match warning due to free_raw_capacity()
2017-09-25 23:20 ` Viresh Kumar
2017-10-06 1:40 ` Sodagudi Prasad
@ 2017-10-10 7:34 ` Prasad Sodagudi
1 sibling, 0 replies; 4+ messages in thread
From: Prasad Sodagudi @ 2017-10-10 7:34 UTC (permalink / raw)
To: viresh.kumar, gregkh, juri.lelli; +Cc: linux-kernel, psodagud
Remove the __init annotation from free_raw_capacity() to avoid
the following warning.
The function init_cpu_capacity_callback() references the
function __init free_raw_capacity().
WARNING: vmlinux.o(.text+0x425cc0): Section mismatch in reference
from the function init_cpu_capacity_callback() to the function
.init.text:free_raw_capacity().
Signed-off-by: Prasad Sodagudi <psodagud@codeaurora.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/base/arch_topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
index 6df7d66..0ca4468 100644
--- a/drivers/base/arch_topology.c
+++ b/drivers/base/arch_topology.c
@@ -96,7 +96,7 @@ static int register_cpu_capacity_sysctl(void)
static u32 capacity_scale;
static u32 *raw_capacity;
-static int __init free_raw_capacity(void)
+static int free_raw_capacity(void)
{
kfree(raw_capacity);
raw_capacity = NULL;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-10 7:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-25 22:51 [PATCH] arch_topology: Fix section miss match warning due to free_raw_capacity() Prasad Sodagudi
2017-09-25 23:20 ` Viresh Kumar
2017-10-06 1:40 ` Sodagudi Prasad
2017-10-10 7:34 ` Prasad Sodagudi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox