From: Ingo Molnar <mingo@kernel.org>
To: Jean Delvare <jdelvare@suse.de>
Cc: x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Alok Kataria <akataria@vmware.com>
Subject: Re: [PATCH] x86/setup: Clarify a comment
Date: Thu, 28 Sep 2017 09:41:08 +0200 [thread overview]
Message-ID: <20170928074108.yvwuoso7xi7qycfb@gmail.com> (raw)
In-Reply-To: <20170919143750.246159e4@endymion>
* Jean Delvare <jdelvare@suse.de> wrote:
> It's not obvious to everybody that BP stands for boot processor. At
> least it was not for me.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Alok Kataria <akataria@vmware.com>
> ---
> arch/x86/kernel/setup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-4.14-rc1.orig/arch/x86/kernel/setup.c 2017-09-17 00:47:51.000000000 +0200
> +++ linux-4.14-rc1/arch/x86/kernel/setup.c 2017-09-19 14:28:30.553830299 +0200
> @@ -1045,7 +1045,7 @@ void __init setup_arch(char **cmdline_p)
>
> /*
> * VMware detection requires dmi to be available, so this
> - * needs to be done after dmi_scan_machine, for the BP.
> + * needs to be done after dmi_scan_machine, for the boot processor.
> */
> init_hypervisor_platform();
Ok, I agree with this change - but there's a couple of other references to 'BP' in
the x86 code, if then we should change all of them over to 'boot CPU'.
Also, while at it, please change 'dmi_scan_machine' to 'dmi_scan_machine()', which
is the canonical way to refer to function calls.
Thanks,
Ingo
prev parent reply other threads:[~2017-09-28 7:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 12:37 [PATCH] x86/setup: Clarify a comment Jean Delvare
2017-09-28 7:41 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170928074108.yvwuoso7xi7qycfb@gmail.com \
--to=mingo@kernel.org \
--cc=akataria@vmware.com \
--cc=hpa@zytor.com \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox