From: Jonathan Corbet <corbet@lwn.net>
To: Borislav Petkov <bp@alien8.de>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-doc@vger.kernel.org
Subject: Re: [PATCH] Documentation: Improve softlockup_panic= description text
Date: Tue, 3 Oct 2017 14:39:17 -0600 [thread overview]
Message-ID: <20171003143917.521c0649@lwn.net> (raw)
In-Reply-To: <20171003155407.25471-1-bp@alien8.de>
On Tue, 3 Oct 2017 17:54:07 +0200
Borislav Petkov <bp@alien8.de> wrote:
> It should say what that <integer> range is and what that integer value
> means. I had to look at the code...
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: linux-doc@vger.kernel.org
> ---
> Documentation/admin-guide/kernel-parameters.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 9a84483db403..c14cd2645c1f 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -3887,6 +3887,12 @@
> [KNL] Should the soft-lockup detector generate panics.
> Format: <integer>
>
> + A non-null value "instructs" the soft-lockup detector
> + to panic the machine when a soft-lockup occurs. This
> + is also controlled by CONFIG_BOOTPARAM_SOFTLOCKUP_PANIC
> + which is the respective build-time switch to that
> + functionality.
So I hate to be fussy. (OK, perhaps I like it, but I'll act reluctant
anyway...:) If it's an integer value, how can it be null? Can we say "a
non-zero value" instead? I'd take out the quotes too, but that's extra
credit...
Thanks,
jon
next prev parent reply other threads:[~2017-10-03 20:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 15:54 [PATCH] Documentation: Improve softlockup_panic= description text Borislav Petkov
2017-10-03 20:39 ` Jonathan Corbet [this message]
2017-10-03 20:54 ` Borislav Petkov
2017-10-03 21:13 ` Jonathan Corbet
2017-10-03 21:26 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003143917.521c0649@lwn.net \
--to=corbet@lwn.net \
--cc=bp@alien8.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox