From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] objtool: Fix memory leak in decode_instructions()
Date: Fri, 13 Oct 2017 00:06:30 -0500 [thread overview]
Message-ID: <20171013050630.cdax2kxj3yqnaton@treble> (raw)
In-Reply-To: <1297c97f-844b-0631-311d-8e3742f2f74f@linux.vnet.ibm.com>
On Fri, Oct 13, 2017 at 10:14:36AM +0530, Kamalesh Babulal wrote:
> On Thursday 12 October 2017 09:40 PM, Josh Poimboeuf wrote:
> > On Thu, Oct 12, 2017 at 02:32:14PM +0530, Kamalesh Babulal wrote:
> > > free the allocated insn before returning, when an error occurs
> > > before adding insn to file->insn_list.
> > >
> > > Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> >
> > Any chance you're working on porting objtool to ppc64le? :-)
> >
> > Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
> >
>
> Thanks for the review. I have started working on it :)
Good! Let me know if you have any questions.
I originally wrote objtool with arch-independence in mind, though with
the new "objtool 2.0" rewrite, it unfortunately became more
x86-specific.
I was hoping to work on making it more arch-independent, and then start
porting it to other arches, but it may be a few months before I have the
time to do so. So any work you want to there would be great.
--
Josh
next prev parent reply other threads:[~2017-10-13 5:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 9:02 [PATCH] objtool: Fix memory leak in decode_instructions() Kamalesh Babulal
2017-10-12 16:10 ` Josh Poimboeuf
2017-10-13 4:44 ` Kamalesh Babulal
2017-10-13 5:06 ` Josh Poimboeuf [this message]
2017-10-13 5:50 ` Kamalesh Babulal
2017-10-19 14:31 ` Josh Poimboeuf
2017-10-19 14:32 ` Josh Poimboeuf
2017-10-22 9:25 ` Kamalesh Babulal
2017-10-19 14:12 ` Josh Poimboeuf
2017-10-19 15:21 ` Ingo Molnar
2017-10-19 15:34 ` Josh Poimboeuf
2017-10-20 7:24 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2017-10-19 16:27 Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013050630.cdax2kxj3yqnaton@treble \
--to=jpoimboe@redhat.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox