From: "Tobin C. Harding" <me@tobin.cc>
To: sunil.m@techveda.org
Cc: gilad@benyossef.com, gregkh@linuxfoundation.org,
linux-crypto@vger.kernel.org,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
karthik@techveda.org
Subject: Re: [PATCH v2] staging: ccree: fix boolreturn.cocci warning
Date: Wed, 18 Oct 2017 13:36:07 +1100 [thread overview]
Message-ID: <20171018023607.GE30848@eros> (raw)
In-Reply-To: <1508292773-15853-1-git-send-email-sunil.m@techveda.org>
On Wed, Oct 18, 2017 at 07:42:53AM +0530, sunil.m@techveda.org wrote:
> From: Suniel Mahesh <sunil.m@techveda.org>
>
> Return "false" instead of 0.
>
> This fixes the following coccinelle warning:
> WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool.
So close! The order of problem description and fix is inverted. What about
```
coccinelle emits: WARNING: return of 0/1 in function 'ssi_is_hw_key' with
return type bool.
Return "false" instead of 0.
```
Good luck,
Tobin.
next prev parent reply other threads:[~2017-10-18 2:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 10:09 [PATCH] staging: ccree: fix boolreturn.cocci warning sunil.m
2017-10-16 21:19 ` Tobin C. Harding
2017-10-18 2:12 ` [PATCH v2] " sunil.m
2017-10-18 2:36 ` Tobin C. Harding [this message]
2017-10-18 6:41 ` [PATCH v3] " sunil.m
2017-10-18 20:54 ` Tobin C. Harding
2017-10-19 6:22 ` Suniel Mahesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018023607.GE30848@eros \
--to=me@tobin.cc \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gilad@benyossef.com \
--cc=gregkh@linuxfoundation.org \
--cc=karthik@techveda.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sunil.m@techveda.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox