From: Greg KH <gregkh@linuxfoundation.org>
To: Matthew Giassa <matthew@giassa.net>
Cc: devel@driverdev.osuosl.org, georgiana.chelu93@gmail.com,
johannes.berg@intel.com, linux-kernel@vger.kernel.org,
kvalo@codeaurora.org, davem@davemloft.net, khoroshilov@ispras.ru,
Larry.Finger@lwfinger.net
Subject: Re: [PATCH] staging: rtlwifi: remove duplicated macros in comments
Date: Wed, 18 Oct 2017 15:47:18 +0200 [thread overview]
Message-ID: <20171018134718.GA32092@kroah.com> (raw)
In-Reply-To: <1507247071-2224-1-git-send-email-matthew@giassa.net>
On Thu, Oct 05, 2017 at 04:44:31PM -0700, Matthew Giassa wrote:
> Removing a comment that duplicates definitions for pci_power_t
> enumeration, and pointing to the relevant header file (current comment
> is also missing PCI_POWER_ERROR).
>
> Signed-off-by: Matthew Giassa <matthew@giassa.net>
> ---
> drivers/staging/rtlwifi/pci.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/staging/rtlwifi/pci.c b/drivers/staging/rtlwifi/pci.c
> index 4035b88..2e2cd21 100644
> --- a/drivers/staging/rtlwifi/pci.c
> +++ b/drivers/staging/rtlwifi/pci.c
> @@ -2456,12 +2456,7 @@ void rtl_pci_disconnect(struct pci_dev *pdev)
> #ifdef CONFIG_PM_SLEEP
> /***************************************
> * kernel pci power state define:
> - * PCI_D0 ((pci_power_t __force) 0)
> - * PCI_D1 ((pci_power_t __force) 1)
> - * PCI_D2 ((pci_power_t __force) 2)
> - * PCI_D3hot ((pci_power_t __force) 3)
> - * PCI_D3cold ((pci_power_t __force) 4)
> - * PCI_UNKNOWN ((pci_power_t __force) 5)
> + * Refer to include/linux/pci.h
That's really vague, how about just deleting these lines, and the
previous one as well?
thanks,
greg k-h
prev parent reply other threads:[~2017-10-18 13:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 23:44 [PATCH] staging: rtlwifi: remove duplicated macros in comments Matthew Giassa
2017-10-18 13:47 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018134718.GA32092@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=georgiana.chelu93@gmail.com \
--cc=johannes.berg@intel.com \
--cc=khoroshilov@ispras.ru \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@giassa.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox