* [PATCH] soc: qcom: remove unused label
@ 2017-10-18 8:30 Arnd Bergmann
2017-11-03 12:25 ` Arnd Bergmann
2017-11-03 13:17 ` Alex Elder
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2017-10-18 8:30 UTC (permalink / raw)
To: Andy Gross, David Brown
Cc: Arnd Bergmann, Rob Herring, Bjorn Andersson, linux-arm-msm,
linux-soc, linux-kernel
The newly added driver comes with a harmless warning:
drivers/soc/qcom/rmtfs_mem.c: In function 'qcom_rmtfs_mem_probe':
drivers/soc/qcom/rmtfs_mem.c:211:1: error: label 'remove_cdev' defined but not used [-Werror=unused-label]
This removes the unused label to avoid the warning.
Fixes: 702baebb8e00 ("soc: qcom: Remote filesystem memory driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/soc/qcom/rmtfs_mem.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/soc/qcom/rmtfs_mem.c b/drivers/soc/qcom/rmtfs_mem.c
index f6f2f0cb3b3a..ce35ff748adf 100644
--- a/drivers/soc/qcom/rmtfs_mem.c
+++ b/drivers/soc/qcom/rmtfs_mem.c
@@ -208,8 +208,6 @@ static int qcom_rmtfs_mem_probe(struct platform_device *pdev)
return 0;
-remove_cdev:
- cdev_device_del(&rmtfs_mem->cdev, &rmtfs_mem->dev);
put_device:
put_device(&rmtfs_mem->dev);
--
2.9.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] soc: qcom: remove unused label
2017-10-18 8:30 [PATCH] soc: qcom: remove unused label Arnd Bergmann
@ 2017-11-03 12:25 ` Arnd Bergmann
2017-11-03 22:00 ` Bjorn Andersson
2017-11-03 13:17 ` Alex Elder
1 sibling, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2017-11-03 12:25 UTC (permalink / raw)
To: Andy Gross, David Brown
Cc: Arnd Bergmann, Rob Herring, Bjorn Andersson, linux-arm-msm,
linux-soc, Linux Kernel Mailing List
On Wed, Oct 18, 2017 at 10:30 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The newly added driver comes with a harmless warning:
>
> drivers/soc/qcom/rmtfs_mem.c: In function 'qcom_rmtfs_mem_probe':
> drivers/soc/qcom/rmtfs_mem.c:211:1: error: label 'remove_cdev' defined but not used [-Werror=unused-label]
>
> This removes the unused label to avoid the warning.
>
> Fixes: 702baebb8e00 ("soc: qcom: Remote filesystem memory driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I just noticed that the build bots now show the warning
arm-soc/next/drivers, so I've
applied my patch on top of that branch.
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] soc: qcom: remove unused label
2017-11-03 12:25 ` Arnd Bergmann
@ 2017-11-03 22:00 ` Bjorn Andersson
0 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2017-11-03 22:00 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Andy Gross, David Brown, Rob Herring, linux-arm-msm, linux-soc,
Linux Kernel Mailing List
On Fri 03 Nov 05:25 PDT 2017, Arnd Bergmann wrote:
> On Wed, Oct 18, 2017 at 10:30 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > The newly added driver comes with a harmless warning:
> >
> > drivers/soc/qcom/rmtfs_mem.c: In function 'qcom_rmtfs_mem_probe':
> > drivers/soc/qcom/rmtfs_mem.c:211:1: error: label 'remove_cdev' defined but not used [-Werror=unused-label]
> >
> > This removes the unused label to avoid the warning.
> >
> > Fixes: 702baebb8e00 ("soc: qcom: Remote filesystem memory driver")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> I just noticed that the build bots now show the warning
> arm-soc/next/drivers, so I've
> applied my patch on top of that branch.
>
Okay, that sounds good. Sorry for missing your previous email.
I apparently got that snippet sqaushed into the wrong commit, will add
it back when I post the follow-up patch needing it.
Regards,
Bjorn
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: qcom: remove unused label
2017-10-18 8:30 [PATCH] soc: qcom: remove unused label Arnd Bergmann
2017-11-03 12:25 ` Arnd Bergmann
@ 2017-11-03 13:17 ` Alex Elder
1 sibling, 0 replies; 4+ messages in thread
From: Alex Elder @ 2017-11-03 13:17 UTC (permalink / raw)
To: Arnd Bergmann, Andy Gross, David Brown
Cc: Rob Herring, Bjorn Andersson, linux-arm-msm, linux-soc,
linux-kernel
On 10/18/2017 03:30 AM, Arnd Bergmann wrote:
> The newly added driver comes with a harmless warning:
>
> drivers/soc/qcom/rmtfs_mem.c: In function 'qcom_rmtfs_mem_probe':
> drivers/soc/qcom/rmtfs_mem.c:211:1: error: label 'remove_cdev' defined but not used [-Werror=unused-label]
>
> This removes the unused label to avoid the warning.
>
> Fixes: 702baebb8e00 ("soc: qcom: Remote filesystem memory driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Looks good.
Reviewed-by: Alex Elder <elder@linaro.org>
> ---
> drivers/soc/qcom/rmtfs_mem.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/qcom/rmtfs_mem.c b/drivers/soc/qcom/rmtfs_mem.c
> index f6f2f0cb3b3a..ce35ff748adf 100644
> --- a/drivers/soc/qcom/rmtfs_mem.c
> +++ b/drivers/soc/qcom/rmtfs_mem.c
> @@ -208,8 +208,6 @@ static int qcom_rmtfs_mem_probe(struct platform_device *pdev)
>
> return 0;
>
> -remove_cdev:
> - cdev_device_del(&rmtfs_mem->cdev, &rmtfs_mem->dev);
> put_device:
> put_device(&rmtfs_mem->dev);
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-03 22:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-18 8:30 [PATCH] soc: qcom: remove unused label Arnd Bergmann
2017-11-03 12:25 ` Arnd Bergmann
2017-11-03 22:00 ` Bjorn Andersson
2017-11-03 13:17 ` Alex Elder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox