The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Huang Rui <ray.huang@amd.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: perf/x86/amd/power missing pmu::module initialisation
Date: Tue, 7 Nov 2017 20:54:44 +0800	[thread overview]
Message-ID: <20171107125443.GA11101@hr-amur2> (raw)
In-Reply-To: <20171107125046.GA10337@hr-amur2>

On Tue, Nov 07, 2017 at 08:50:52PM +0800, Huang Rui wrote:
> Hi Mark,
> 
> On Fri, Nov 03, 2017 at 11:33:56AM +0000, Mark Rutland wrote:
> > Hi,
> > 
> > As a heads-up, I believe that arch/x86/events/amd/power.c is currently
> > missing initialisation of pmu::module, which could result in problems
> > when the module is unloaded.
> > 
> > We've just spotted a similar problem in a couple of ARM PMUs, and AFAICT
> > the AMD power PMU is the only other PMU affected.
> > 
> > Other modular PMUs all initialise this to THIS_MODULE prior to calling
> > perf_pmu_register().
> > 
> 
> Thanks to let me know. I have dived into pmu for quite a while. Could you

Fix typo -> "I haven't dived into ..."

Thanks,
Rui

  reply	other threads:[~2017-11-07 12:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03 11:33 perf/x86/amd/power missing pmu::module initialisation Mark Rutland
2017-11-07 12:50 ` Huang Rui
2017-11-07 12:54   ` Huang Rui [this message]
2017-11-20 15:55   ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171107125443.GA11101@hr-amur2 \
    --to=ray.huang@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox