public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: David Kershner <david.kershner@unisys.com>
Cc: jes.sorensen@gmail.com, linux-kernel@vger.kernel.org,
	driverdev-devel@linuxdriverproject.org,
	sparmaintainer@unisys.com, erik.arfvidson@gmail.com,
	wadgaonkarsam@gmail.com
Subject: Re: [PATCH 2/2] drivers: visorbus: move driver out of staging
Date: Sat, 18 Nov 2017 11:26:21 +0100	[thread overview]
Message-ID: <20171118102621.GE8368@kroah.com> (raw)
In-Reply-To: <1510939659-15039-3-git-send-email-david.kershner@unisys.com>

On Fri, Nov 17, 2017 at 12:27:39PM -0500, David Kershner wrote:
>  {drivers/staging/unisys/include => include/linux/visorbus}/visorbus.h | 0
>  .../staging/unisys/include => include/linux/visorbus}/visorchannel.h  | 0

Do we really need two different include/linux .h files for this bus
subsystem?  Can we merge them both together?

> diff --git a/drivers/staging/unisys/visorbus/Kconfig b/drivers/visorbus/Kconfig
> similarity index 90%
> rename from drivers/staging/unisys/visorbus/Kconfig
> rename to drivers/visorbus/Kconfig
> index 5113880..a99285a 100644
> --- a/drivers/staging/unisys/visorbus/Kconfig
> +++ b/drivers/visorbus/Kconfig
> @@ -4,7 +4,9 @@
>  
>  config UNISYS_VISORBUS
>  	tristate "Unisys visorbus driver"
> -	depends on UNISYSSPAR
> +	depends on X86_64 && !UML
> +	select PCI
> +	select ACPI

Wait, what?  Why are you messing with the dependancies now?  And never
do a select if at all possible, do a 'depends on' instead.

And why not UML?  What about other arches, why are you now restricting
it?  That's an odd change to be doing here in a "move this out of
staging" patch...

thanks,

greg k-h

  parent reply	other threads:[~2017-11-18 10:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-17 17:27 [PATCH 0/2] drivers: Move visorbus from staging to drivers/visorbus David Kershner
2017-11-17 17:27 ` [PATCH 1/2] staging: unisys: visorbus: address theoretical int overflows David Kershner
2017-11-28 14:11   ` Dan Carpenter
2017-11-17 17:27 ` [PATCH 2/2] drivers: visorbus: move driver out of staging David Kershner
2017-11-17 19:17   ` Christoph Hellwig
2017-11-17 21:11     ` Kershner, David A
2017-11-18 10:26   ` Greg KH [this message]
2017-11-18 14:30     ` Kershner, David A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171118102621.GE8368@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=david.kershner@unisys.com \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=erik.arfvidson@gmail.com \
    --cc=jes.sorensen@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparmaintainer@unisys.com \
    --cc=wadgaonkarsam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox