From: Mikhail Zaytsev <flashed@mail.ru>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>,
<usb-storage@lists.one-eyed-alien.net>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] USB: storage: Notify the subdrivers that they need to reinitialize the device.
Date: Thu, 30 Nov 2017 00:03:53 +0300 [thread overview]
Message-ID: <20171130000353.6de42104@debian> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1711291041340.1369-100000@iolanthe.rowland.org>
On Wed, 29 Nov 2017 Alan Stern <stern@rowland.harvard.edu> wrote:
> On Wed, 29 Nov 2017, Mikhail Zaytsev wrote:
>
> > This patch adds the device_reinit function into the us_data
> > structure. The usb-storage driver uses this function for notify the
> > subdrivers that they need to reinitialize the device.
> >
> > Signed-off-by: Mikhail Zaytsev <flashed@mail.ru>
>
> I'd feel more inclined to accept this patch if the new code got used
> somewhere. As it is, it fixes a "problem" that doesn't actually have
> any real effect.
>
> Alan Stern
I propose to delete this FIXME comments without any code changes.
Regards, Mikhail
next prev parent reply other threads:[~2017-11-29 21:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 9:46 [PATCH v1] USB: storage: Notify the subdrivers that they need to reinitialize the device Mikhail Zaytsev
2017-11-29 15:42 ` Alan Stern
2017-11-29 21:03 ` Mikhail Zaytsev [this message]
2017-11-29 21:11 ` Alan Stern
2017-11-30 8:54 ` [PATCH v1] USB: storage: Remove obsolete "FIXME" Mikhail Zaytsev
2017-11-30 15:57 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130000353.6de42104@debian \
--to=flashed@mail.ru \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox