The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Mikhail Zaytsev <flashed@mail.ru>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<linux-usb@vger.kernel.org>,
	<usb-storage@lists.one-eyed-alien.net>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH v1] USB: storage: Remove obsolete "FIXME"
Date: Thu, 30 Nov 2017 11:54:07 +0300	[thread overview]
Message-ID: <20171130115407.35e5e8a2@zaitsev.tver.pg> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1711291610360.1369-100000@iolanthe.rowland.org>

The fix of "FIXME: Notify the subdrivers..." doesn't actually have any
 real effect. The "FIXME" changed to simple comment. 

Signed-off-by: Mikhail Zaytsev <flashed@mail.ru>
---
 drivers/usb/storage/usb.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c
index a0c07e0..3eb9347 100644
--- a/drivers/usb/storage/usb.c
+++ b/drivers/usb/storage/usb.c
@@ -211,8 +211,8 @@ int usb_stor_reset_resume(struct usb_interface *iface)
 	usb_stor_report_bus_reset(us);
 
 	/*
-	 * FIXME: Notify the subdrivers that they need to reinitialize
-	 * the device
+	 * If any of the subdrivers implemented a reinitialization scheme,
+	 * this is where the callback would be invoked.
 	 */
 	return 0;
 }
@@ -243,8 +243,8 @@ int usb_stor_post_reset(struct usb_interface *iface)
 	usb_stor_report_bus_reset(us);
 
 	/*
-	 * FIXME: Notify the subdrivers that they need to reinitialize
-	 * the device
+	 * If any of the subdrivers implemented a reinitialization scheme,
+	 * this is where the callback would be invoked.
 	 */
 
 	mutex_unlock(&us->dev_mutex);
-- 
2.1.4

  reply	other threads:[~2017-11-30  8:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29  9:46 [PATCH v1] USB: storage: Notify the subdrivers that they need to reinitialize the device Mikhail Zaytsev
2017-11-29 15:42 ` Alan Stern
2017-11-29 21:03   ` Mikhail Zaytsev
2017-11-29 21:11     ` Alan Stern
2017-11-30  8:54       ` Mikhail Zaytsev [this message]
2017-11-30 15:57         ` [PATCH v1] USB: storage: Remove obsolete "FIXME" Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171130115407.35e5e8a2@zaitsev.tver.pg \
    --to=flashed@mail.ru \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=usb-storage@lists.one-eyed-alien.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox