From: Eduardo Valentin <edubezval@gmail.com>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: rui.zhang@intel.com, srikars@nvidia.com,
thierry.reding@gmail.com, jonathanh@nvidia.com,
linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thermal: tegra: allow sensor registeration to fail
Date: Mon, 4 Dec 2017 18:46:28 -0800 [thread overview]
Message-ID: <20171205024625.GC4949@localhost.localdomain> (raw)
In-Reply-To: <1509148453-11388-1-git-send-email-nicoleotsuka@gmail.com>
Hello,
On Fri, Oct 27, 2017 at 04:54:13PM -0700, Nicolin Chen wrote:
> Not all sensors may be used on a platform. So there could be
> some missing thermal zones in the Device Tree. However, the
> the driver now errors out whenever a sensor fails to register
> the thermal zone.
>
> Since the driver could live with other sensors, this change
> allows other sensors to continue the registerations even if
> one sensor fails to register.
What would be the use case you want to have your chip running with
failed to probe thermal zones ? If they are failing to probe
shouldnt you fix the DT nodes?
a system with correct DT, failed to probe zones is a real bug.
Either in the DT or in the code.
>
> Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
> ---
>
prev parent reply other threads:[~2017-12-05 2:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 23:54 [PATCH] thermal: tegra: allow sensor registeration to fail Nicolin Chen
2017-12-05 2:46 ` Eduardo Valentin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205024625.GC4949@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=rui.zhang@intel.com \
--cc=srikars@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox