public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Tobin C. Harding" <me@tobin.cc>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Andy Whitcroft <apw@canonical.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: warn for use of %px
Date: Wed, 6 Dec 2017 07:27:21 +1100	[thread overview]
Message-ID: <20171205202721.GC11064@eros> (raw)
In-Reply-To: <1512487638.6321.80.camel@perches.com>

On Tue, Dec 05, 2017 at 07:27:18AM -0800, Joe Perches wrote:
> On Tue, 2017-12-05 at 20:44 +1100, Tobin C. Harding wrote:
> > On Mon, Dec 04, 2017 at 11:24:24PM -0800, Joe Perches wrote:
> > > On Tue, 2017-12-05 at 08:17 +1100, Tobin C. Harding wrote:
> > > > Usage of the new %px specifier potentially leaks sensitive
> > > > inforamtion. Printing kernel addresses exposes the kernel layout in
> > > 
> > > information
> 
> > I don't understand this comment? Do you mean the wording is wrong?
> > I'll re-word as suggested below.
> 
> It's just a spelling typo correction.

ha ha, note to self - be careful doing kernel email late at night :)

> []
> > > > Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> > > > Signed-off-by: Tobin C. Harding <me@tobin.cc>
> > > > Co-Developed-by: Joe Perches <joe@perches.com>
> > > > Are you happy with this tagging? Needs your signed-off-by still.
> 
> I think signatures tags are pretty freeform and
> I'm not particularly concerned about them.
> 
> I think Andrew Morton may object and change it
> or remove it.  Have an:
> 
> Acked-by: Joe Perches <joe@perches.com>

Cool, will add and re-spin

thanks,
Tobin.

      reply	other threads:[~2017-12-05 20:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-04 21:17 [PATCH] checkpatch: warn for use of %px Tobin C. Harding
2017-12-05  7:24 ` Joe Perches
2017-12-05  9:44   ` Tobin C. Harding
2017-12-05 15:27     ` Joe Perches
2017-12-05 20:27       ` Tobin C. Harding [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171205202721.GC11064@eros \
    --to=me@tobin.cc \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox