From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] gpio: fix "gpio-line-names" property retrieval
Date: Fri, 15 Dec 2017 20:39:54 +0200 [thread overview]
Message-ID: <20171215183954.GJ22431@lahna.fi.intel.com> (raw)
In-Reply-To: <20171215140233.804E768968@localhost.localdomain>
On Fri, Dec 15, 2017 at 03:02:33PM +0100, Christophe Leroy wrote:
> Following commit 9427ecbed46cc ("gpio: Rework of_gpiochip_set_names()
> to use device property accessors"), "gpio-line-names" DT property is
> not retrieved anymore when chip->parent is not set by the driver.
> This is due to OF based property reads having been replaced by device
> based property reads.
>
> This patch fixes that by making use of
> fwnode_property_read_string_array() instead of
> device_property_read_string_array() and handing over either
> of_fwnode_handle(chip->of_node) or dev_fwnode(chip->parent)
> to that function.
>
> Fixes: 9427ecbed46cc ("gpio: Rework of_gpiochip_set_names() to use device property accessors")
> Cc: stable@vger.kernel.org
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2017-12-15 18:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 14:02 [PATCH v2] gpio: fix "gpio-line-names" property retrieval Christophe Leroy
2017-12-15 18:39 ` Mika Westerberg [this message]
2017-12-20 8:21 ` Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2017-12-15 13:51 chleroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215183954.GJ22431@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=christophe.leroy@c-s.fr \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox