[PATCH v2] USB: serial: option: adding support for YUGA CLM920-NC5

[PATCH v2] USB: serial: option: adding support for YUGA CLM920-NC5

[SZ Lin (林上智)]

This patch adds support for YUGA CLM920-NC5 PID 0x9625 USB modem to option
driver.

Interface layout:
0: QCDM/DIAG
1: ADB
2: MODEM
3: AT
4: RMNET

Signed-off-by: Taiyi Wu <taiyity.wu@moxa.com>
Signed-off-by: SZ Lin (林上智) <sz.lin@moxa.com>
---
Changes from v1:
- Fix typo
- Remove QCDM/DIAG interface in blacklist

 drivers/usb/serial/option.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 3b3513874cfd..8a50226379b0 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -233,6 +233,8 @@ static void option_instat_callback(struct urb *urb);
 /* These Quectel products use Qualcomm's vendor ID */
 #define QUECTEL_PRODUCT_UC20			0x9003
 #define QUECTEL_PRODUCT_UC15			0x9090
+/* These Yuga products use Qualcomm's vendor ID */
+#define YUGA_PRODUCT_CLM920_NC5			0x9625
 
 #define QUECTEL_VENDOR_ID			0x2c7c
 /* These Quectel products use Quectel's vendor ID */
@@ -674,6 +676,10 @@ static const struct option_blacklist_info cinterion_rmnet2_blacklist = {
 	.reserved = BIT(4) | BIT(5),
 };
 
+static const struct option_blacklist_info yuga_clm920_nc5_blacklist = {
+	.reserved = BIT(1) | BIT(4),
+};
+
 static const struct usb_device_id option_ids[] = {
 	{ USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_COLT) },
 	{ USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_RICOLA) },
@@ -1178,6 +1184,9 @@ static const struct usb_device_id option_ids[] = {
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC15)},
 	{ USB_DEVICE(QUALCOMM_VENDOR_ID, QUECTEL_PRODUCT_UC20),
 	  .driver_info = (kernel_ulong_t)&net_intf4_blacklist },
+	/* Yuga products use Qualcomm vendor ID */
+	{ USB_DEVICE(QUALCOMM_VENDOR_ID, YUGA_PRODUCT_CLM920_NC5),
+	  .driver_info = (kernel_ulong_t)&yuga_clm920_nc5_blacklist },
 	/* Quectel products using Quectel vendor ID */
 	{ USB_DEVICE(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC21),
 	  .driver_info = (kernel_ulong_t)&net_intf4_blacklist },
-- 
2.15.1

Re: [PATCH v2] USB: serial: option: adding support for YUGA CLM920-NC5

[Johan Hovold]

On Tue, Dec 19, 2017 at 05:40:32PM +0800, SZ Lin (林上智) wrote:
> This patch adds support for YUGA CLM920-NC5 PID 0x9625 USB modem to option
> driver.
> 
> Interface layout:
> 0: QCDM/DIAG
> 1: ADB
> 2: MODEM
> 3: AT
> 4: RMNET
> 
> Signed-off-by: Taiyi Wu <taiyity.wu@moxa.com>
> Signed-off-by: SZ Lin (林上智) <sz.lin@moxa.com>
> ---
> Changes from v1:
> - Fix typo
> - Remove QCDM/DIAG interface in blacklist

Thanks for the v2. Patch looks good now, but it seems your name cannot
be represented in UTF-8 (or my setup is broken).

I see you have used the latin version "SF Lin" in the past so that
should be fine. I was just asking to make sure "SF" wasn't an acronym or
nickname.

Care to resend a v3 with your original From and Signed-off-by?

Thanks,
Johan

Re: [PATCH v2] USB: serial: option: adding support for YUGA CLM920-NC5

[Johan Hovold]

On Tue, Dec 19, 2017 at 11:11:43AM +0100, Johan Hovold wrote:
> On Tue, Dec 19, 2017 at 05:40:32PM +0800, SZ Lin (林上智) wrote:
> > This patch adds support for YUGA CLM920-NC5 PID 0x9625 USB modem to option
> > driver.
> > 
> > Interface layout:
> > 0: QCDM/DIAG
> > 1: ADB
> > 2: MODEM
> > 3: AT
> > 4: RMNET
> > 
> > Signed-off-by: Taiyi Wu <taiyity.wu@moxa.com>
> > Signed-off-by: SZ Lin (林上智) <sz.lin@moxa.com>
> > ---
> > Changes from v1:
> > - Fix typo
> > - Remove QCDM/DIAG interface in blacklist
> 
> Thanks for the v2. Patch looks good now, but it seems your name cannot
> be represented in UTF-8 (or my setup is broken).
> 
> I see you have used the latin version "SF Lin" in the past so that
> should be fine. I was just asking to make sure "SF" wasn't an acronym or
> nickname.

Sorry, I meant "SZ Lin" of course.

> Care to resend a v3 with your original From and Signed-off-by?
 
Thanks,
Johan

Re: [PATCH v2] USB: serial: option: adding support for YUGA CLM920-NC5

[Johan Hovold]

On Tue, Dec 19, 2017 at 11:14:37AM +0100, Johan Hovold wrote:
> On Tue, Dec 19, 2017 at 11:11:43AM +0100, Johan Hovold wrote:
> > On Tue, Dec 19, 2017 at 05:40:32PM +0800, SZ Lin (林上智) wrote:
> > > This patch adds support for YUGA CLM920-NC5 PID 0x9625 USB modem to option
> > > driver.
> > > 
> > > Interface layout:
> > > 0: QCDM/DIAG
> > > 1: ADB
> > > 2: MODEM
> > > 3: AT
> > > 4: RMNET
> > > 
> > > Signed-off-by: Taiyi Wu <taiyity.wu@moxa.com>
> > > Signed-off-by: SZ Lin (林上智) <sz.lin@moxa.com>
> > > ---
> > > Changes from v1:
> > > - Fix typo
> > > - Remove QCDM/DIAG interface in blacklist
> > 
> > Thanks for the v2. Patch looks good now, but it seems your name cannot
> > be represented in UTF-8 (or my setup is broken).
> > 
> > I see you have used the latin version "SF Lin" in the past so that
> > should be fine. I was just asking to make sure "SF" wasn't an acronym or
> > nickname.
> 
> Sorry, I meant "SZ Lin" of course.
> 
> > Care to resend a v3 with your original From and Signed-off-by?

Nevermind, it seems it's just my terminals that can't represent it. I'll
apply the patch as is.

Sorry about the noise.

Johan

RE: [PATCH v2] USB: serial: option: adding support for YUGA CLM920-NC5

[SZ Lin (林上智)]

> On Tue, Dec 19, 2017 at 11:14:37AM +0100, Johan Hovold wrote:
> > On Tue, Dec 19, 2017 at 11:11:43AM +0100, Johan Hovold wrote:
> > > On Tue, Dec 19, 2017 at 05:40:32PM +0800, SZ Lin (林上智) wrote:
> > > > This patch adds support for YUGA CLM920-NC5 PID 0x9625 USB modem
> > > > to option driver.
> > > >
> > > > Interface layout:
> > > > 0: QCDM/DIAG
> > > > 1: ADB
> > > > 2: MODEM
> > > > 3: AT
> > > > 4: RMNET
> > > >
> > > > Signed-off-by: Taiyi Wu <taiyity.wu@moxa.com>
> > > > Signed-off-by: SZ Lin (林上智) <sz.lin@moxa.com>
> > > > ---
> > > > Changes from v1:
> > > > - Fix typo
> > > > - Remove QCDM/DIAG interface in blacklist
> > >
> > > Thanks for the v2. Patch looks good now, but it seems your name
> > > cannot be represented in UTF-8 (or my setup is broken).
> > >
> > > I see you have used the latin version "SF Lin" in the past so that
> > > should be fine. I was just asking to make sure "SF" wasn't an
> > > acronym or nickname.
> >
> > Sorry, I meant "SZ Lin" of course.
> >
> > > Care to resend a v3 with your original From and Signed-off-by?
> 
> Nevermind, it seems it's just my terminals that can't represent it. I'll apply the patch as is.
> 

Thank you and thanks to Bjorn.

> Sorry about the noise.
> 
> Johan

RE: [PATCH v2] USB: serial: option: adding support for YUGA CLM920-NC5

[SZ Lin (林上智)]

> -----Original Message-----
> From: Johan Hovold [mailto:jhovold@gmail.com] On Behalf Of Johan Hovold
> Sent: Tuesday, December 19, 2017 6:12 PM
> To: SZ Lin (林上智)
> Cc: bjorn@mork.no; Taiyi TY Wu (吳泰毅); Johan Hovold; Greg Kroah-Hartman;
> linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2] USB: serial: option: adding support for YUGA CLM920-NC5
> 
> On Tue, Dec 19, 2017 at 05:40:32PM +0800, SZ Lin (林上智) wrote:
> > This patch adds support for YUGA CLM920-NC5 PID 0x9625 USB modem to
> > option driver.
> >
> > Interface layout:
> > 0: QCDM/DIAG
> > 1: ADB
> > 2: MODEM
> > 3: AT
> > 4: RMNET
> >
> > Signed-off-by: Taiyi Wu <taiyity.wu@moxa.com>
> > Signed-off-by: SZ Lin (林上智) <sz.lin@moxa.com>
> > ---
> > Changes from v1:
> > - Fix typo
> > - Remove QCDM/DIAG interface in blacklist
> 
> Thanks for the v2. Patch looks good now, but it seems your name cannot be represented in
> UTF-8 (or my setup is broken).
> 
> I see you have used the latin version "SF Lin" in the past so that should be fine. I was just
> asking to make sure "SF" wasn't an acronym or nickname.
> 
> Care to resend a v3 with your original From and Signed-off-by?
> 

SZ Lin (林上智) is my legal name, but it causes garbled issue in some environment. 
Therefore, I usually use SZ Lin as my legal name in patch.

> Thanks,
> Johan