From: Dan Carpenter <dan.carpenter@oracle.com>
To: George Edward Bulmer <gebulmer@googlemail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
lars@metafoo.de, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de,
jic23@kernel.org
Subject: Re: [PATCH] staging: iio: light: Add breaks to lengthy lines
Date: Mon, 8 Jan 2018 14:48:43 +0300 [thread overview]
Message-ID: <20180108114843.burtlxsfarp3uqlp@mwanda> (raw)
In-Reply-To: <20180107150801.21617-1-gebulmer@googlemail.com>
On Sun, Jan 07, 2018 at 03:08:01PM +0000, George Edward Bulmer wrote:
> This fixes three instances of checkpatch warning:
> WARNING: line over 80 characters
>
> Signed-off-by: George Edward Bulmer <gebulmer@googlemail.com>
> ---
> drivers/staging/iio/light/tsl2x7x.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/iio/light/tsl2x7x.c b/drivers/staging/iio/light/tsl2x7x.c
> index 42ed9c015aaf..126e11530ce0 100644
> --- a/drivers/staging/iio/light/tsl2x7x.c
> +++ b/drivers/staging/iio/light/tsl2x7x.c
> @@ -1441,7 +1441,8 @@ static irqreturn_t tsl2x7x_event_handler(int irq, void *private)
>
> static struct attribute *tsl2x7x_ALS_device_attrs[] = {
> &dev_attr_in_illuminance0_calibscale_available.attr,
> - &iio_const_attr_in_illuminance0_integration_time_available.dev_attr.attr,
> + &iio_const_attr_in_illuminance0_integration_time_available
> + .dev_attr.attr,
Ugh. No. The original was better.
regards,
dan carpenter
prev parent reply other threads:[~2018-01-08 11:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-07 15:08 [PATCH] staging: iio: light: Add breaks to lengthy lines George Edward Bulmer
2018-01-07 16:28 ` Jonathan Cameron
2018-01-07 16:42 ` Joe Perches
2018-01-07 17:17 ` Jonathan Cameron
2018-01-08 12:02 ` Dan Carpenter
2018-01-08 14:59 ` Joe Perches
2018-01-08 11:48 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108114843.burtlxsfarp3uqlp@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gebulmer@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox