* [PATCH] hwmon: pmbus: ibm-cffps depends on LEDS_CLASS
@ 2018-01-12 15:49 Arnd Bergmann
2018-01-12 17:19 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2018-01-12 15:49 UTC (permalink / raw)
To: Guenter Roeck, Jean Delvare
Cc: Arnd Bergmann, Samuel Mendoza-Jonas, Andrew Jeffery,
Edward A. James, linux-hwmon, linux-kernel
Building without CONFIG_LEDS_CLASS causes a link failure:
drivers/hwmon/pmbus/ibm-cffps.o: In function `ibm_cffps_probe':
ibm-cffps.c:(.text+0x4f4): undefined reference to `devm_of_led_classdev_register'
This adds the required dependency.
Fixes: f69316d62c70 ("hwmon: (pmbus) Add IBM Common Form Factor (CFF) power supply driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/hwmon/pmbus/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
index 08479006c7f9..6e4298e99222 100644
--- a/drivers/hwmon/pmbus/Kconfig
+++ b/drivers/hwmon/pmbus/Kconfig
@@ -39,6 +39,7 @@ config SENSORS_ADM1275
config SENSORS_IBM_CFFPS
tristate "IBM Common Form Factor Power Supply"
+ depends on LEDS_CLASS
help
If you say yes here you get hardware monitoring support for the IBM
Common Form Factor power supply.
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hwmon: pmbus: ibm-cffps depends on LEDS_CLASS
2018-01-12 15:49 [PATCH] hwmon: pmbus: ibm-cffps depends on LEDS_CLASS Arnd Bergmann
@ 2018-01-12 17:19 ` Guenter Roeck
0 siblings, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2018-01-12 17:19 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jean Delvare, Samuel Mendoza-Jonas, Andrew Jeffery,
Edward A. James, linux-hwmon, linux-kernel
On Fri, Jan 12, 2018 at 04:49:00PM +0100, Arnd Bergmann wrote:
> Building without CONFIG_LEDS_CLASS causes a link failure:
>
> drivers/hwmon/pmbus/ibm-cffps.o: In function `ibm_cffps_probe':
> ibm-cffps.c:(.text+0x4f4): undefined reference to `devm_of_led_classdev_register'
>
> This adds the required dependency.
>
> Fixes: f69316d62c70 ("hwmon: (pmbus) Add IBM Common Form Factor (CFF) power supply driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I wanted to let Edward decide if he wants the new dependency or conditional code
in the driver. Not having heard from him, I'll take your patch instead for now.
Thanks,
Guenter
> ---
> drivers/hwmon/pmbus/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
> index 08479006c7f9..6e4298e99222 100644
> --- a/drivers/hwmon/pmbus/Kconfig
> +++ b/drivers/hwmon/pmbus/Kconfig
> @@ -39,6 +39,7 @@ config SENSORS_ADM1275
>
> config SENSORS_IBM_CFFPS
> tristate "IBM Common Form Factor Power Supply"
> + depends on LEDS_CLASS
> help
> If you say yes here you get hardware monitoring support for the IBM
> Common Form Factor power supply.
> --
> 2.9.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <ca65ed8a-ac10-641a-a8fc-e042178b7451@linux.vnet.ibm.com>]
* Re: [PATCH] hwmon: pmbus: ibm-cffps depends on LEDS_CLASS
[not found] <ca65ed8a-ac10-641a-a8fc-e042178b7451@linux.vnet.ibm.com>
@ 2018-01-15 15:24 ` Eddie James
0 siblings, 0 replies; 3+ messages in thread
From: Eddie James @ 2018-01-15 15:24 UTC (permalink / raw)
To: Guenter Roeck
Cc: arnd, jdelvare, sam, Andrew Jeffery, linux-hwmon, linux-kernel
On Fri, Jan 12, 2018 at 06:19:00PM +0100, Guenter Roeck wrote:
> On Fri, Jan 12, 2018 at 04:49:00PM +0100, Arnd Bergmann wrote:
> > Building without CONFIG_LEDS_CLASS causes a link failure:
> >
> > drivers/hwmon/pmbus/ibm-cffps.o: In function `ibm_cffps_probe':
> > ibm-cffps.c:(.text+0x4f4): undefined reference to
> `devm_of_led_classdev_register'
> >
> > This adds the required dependency.
> >
> > Fixes: f69316d62c70 ("hwmon: (pmbus) Add IBM Common Form Factor
> (CFF) power supply driver")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> I wanted to let Edward decide if he wants the new dependency or
> conditional code
> in the driver. Not having heard from him, I'll take your patch instead
> for now.
Thanks, yes this is a good solution for this driver. Didn't think about
that during testing... Thanks Arnd.
Eddie
>
> Thanks,
> Guenter
>
> > ---
> > drivers/hwmon/pmbus/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
> > index 08479006c7f9..6e4298e99222 100644
> > --- a/drivers/hwmon/pmbus/Kconfig
> > +++ b/drivers/hwmon/pmbus/Kconfig
> > @@ -39,6 +39,7 @@ config SENSORS_ADM1275
> >
> > config SENSORS_IBM_CFFPS
> > tristate "IBM Common Form Factor Power Supply"
> > + depends on LEDS_CLASS
> > help
> > If you say yes here you get hardware monitoring support for the IBM
> > Common Form Factor power supply.
> > --
> > 2.9.0
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-15 15:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-12 15:49 [PATCH] hwmon: pmbus: ibm-cffps depends on LEDS_CLASS Arnd Bergmann
2018-01-12 17:19 ` Guenter Roeck
[not found] <ca65ed8a-ac10-641a-a8fc-e042178b7451@linux.vnet.ibm.com>
2018-01-15 15:24 ` Eddie James
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox