public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lukas Senger <lukas@fridolin.com>
To: giometti@enneenne.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pps-gpio: implement echo pulses
Date: Thu, 15 Feb 2018 13:59:19 +0100	[thread overview]
Message-ID: <20180215125921.29494-1-lukas@fridolin.com> (raw)
In-Reply-To: <ee4fdd16-0343-1a01-63a7-06046026659a@enneenne.com>

> No hardcoded stuff please! :-D

I expected as much :) So I looked into it a bit more and came up with
the patch below. It works for me but I'm unsure about two things in
particular:

In the __overrides__ section of the *.dts, why does gpiopin set reg and
should echopin set this as well?

In pps-gpio.c:135 how is pdata in the first part of this if-statement
supposed to know about these values?

Thanks,
Lukas

  reply	other threads:[~2018-02-15 13:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06 15:58 [PATCH] pps-gpio: implement echo pulses Lukas Senger
2018-02-07  9:09 ` Rodolfo Giometti
2018-02-15 12:59   ` Lukas Senger [this message]
2018-02-15 12:59     ` [PATCH 1/2] pps-gpio: Avoid flooding syslog Lukas Senger
2018-02-15 13:34       ` Rodolfo Giometti
2018-02-15 15:12         ` Lukas Senger
2018-02-15 15:36           ` Rodolfo Giometti
2018-02-15 19:48             ` Lukas Senger
2018-02-15 12:59     ` [PATCH 2/2] pps-gpio: Set echo GPIO pin via devicetree Lukas Senger
2018-02-15 13:43       ` Rodolfo Giometti
2018-02-15 15:08         ` Lukas Senger
2018-02-15 15:33           ` Rodolfo Giometti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180215125921.29494-1-lukas@fridolin.com \
    --to=lukas@fridolin.com \
    --cc=giometti@enneenne.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox