public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lukas Senger <lukas@fridolin.com>
To: Rodolfo Giometti <giometti@enneenne.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] pps-gpio: Set echo GPIO pin via devicetree
Date: Thu, 15 Feb 2018 16:08:45 +0100	[thread overview]
Message-ID: <20180215160845.72da12c3@dinghy.localdomain> (raw)
In-Reply-To: <eb34d5ef-2e99-5983-8bdd-bf6fd0dc8bd2@enneenne.com>

> > @@ -20,18 +21,20 @@
> >   		target = <&gpio>;
> >   		__overlay__ {
> >   			pps_pins: pps_pins@12 {
> > -				brcm,pins =     <18>;
> > -				brcm,function = <0>;    // in
> > -				brcm,pull =     <0>;    // off
> > +				brcm,pins =     <18 17>;
> > +				brcm,function = <0 1>;    // in
> > out
> > +				brcm,pull =     <0 0>;    // off
> > off  
> 
> These modifications are not PPS related.
> 
> >   			};
> >   		};
> >   	};
> >   
> >   	__overrides__ {
> > -		gpiopin = <&pps>,"gpios:4",
> > +		gpiopin = <&pps>,"in-gpios:4",
> >   			  <&pps>,"reg:0",
> >   			  <&pps_pins>,"brcm,pins:0",
> >   			  <&pps_pins>,"reg:0";
> > +		echopin = <&pps>,"out-gpios:4",
> > +			  <&pps_pins>,"brcm,pins:4";  
> 
> Ditto.

I don't understand why these modifications are unrelated. Especially
the echopin-option should exist, shouldn't it?

Cheers,
Lukas

  reply	other threads:[~2018-02-15 15:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06 15:58 [PATCH] pps-gpio: implement echo pulses Lukas Senger
2018-02-07  9:09 ` Rodolfo Giometti
2018-02-15 12:59   ` Lukas Senger
2018-02-15 12:59     ` [PATCH 1/2] pps-gpio: Avoid flooding syslog Lukas Senger
2018-02-15 13:34       ` Rodolfo Giometti
2018-02-15 15:12         ` Lukas Senger
2018-02-15 15:36           ` Rodolfo Giometti
2018-02-15 19:48             ` Lukas Senger
2018-02-15 12:59     ` [PATCH 2/2] pps-gpio: Set echo GPIO pin via devicetree Lukas Senger
2018-02-15 13:43       ` Rodolfo Giometti
2018-02-15 15:08         ` Lukas Senger [this message]
2018-02-15 15:33           ` Rodolfo Giometti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180215160845.72da12c3@dinghy.localdomain \
    --to=lukas@fridolin.com \
    --cc=giometti@enneenne.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox